-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm backend: Fix bug in ConvertExpandCopyToRepeatPass #7199
base: main
Are you sure you want to change the base?
Arm backend: Fix bug in ConvertExpandCopyToRepeatPass #7199
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7199
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 4d8a7e4 with merge base 62d2e37 (): NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @Aleksei-grovety! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Please seek CI approval before scheduling CIFlow labels |
Hi @Aleksei-grovety ! This needs a rebase pls |
62a2493
to
a378621
Compare
Hi! Thanks for the advice. Done. |
In the ConvertExpandCopyToRepeatPass the arguments for the repeat operation are formed incorrectly. For the torch.Tensor.expand operation passing -1 as the size for a dimension means that the size of that dimension does not change. For the DeiT-tiny case, torch.ones(1, 1, 192).expand(1, -1, -1) the pass will prepare arguments to the repeat operation as [1, -1, 1] which will cause an error, in this case the arguments should be [1, 1, 1].
a378621
to
4d8a7e4
Compare
Thx @Aleksei-grovety! There seem to be a general issue in the CI. See #7285 (comment) |
There's two issues. 1) that you saw in your last log had to do with docker images being push ahead of PR merge. That should be resolved now. 2) this: #7285 (comment) |
@Aleksei-grovety sorry, you need to rebase again for the tests to pass :/ |
In the ConvertExpandCopyToRepeatPass the arguments for the repeat operation are formed incorrectly. For the torch.Tensor.expand operation passing -1 as the size for a dimension means that the size of that dimension does not change. For the DeiT-tiny case, torch.ones(1, 1, 192).expand(1, -1, -1) the pass will prepare arguments to the repeat operation as [1, -1, 1] which will cause an error, in this case the arguments should be [1, 1, 1].