Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm backend: Fix bug in ConvertExpandCopyToRepeatPass #7199

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Aleksei-grovety
Copy link

In the ConvertExpandCopyToRepeatPass the arguments for the repeat operation are formed incorrectly. For the torch.Tensor.expand operation passing -1 as the size for a dimension means that the size of that dimension does not change. For the DeiT-tiny case, torch.ones(1, 1, 192).expand(1, -1, -1) the pass will prepare arguments to the repeat operation as [1, -1, 1] which will cause an error, in this case the arguments should be [1, 1, 1].

Copy link

pytorch-bot bot commented Dec 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7199

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit 4d8a7e4 with merge base 62d2e37 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @Aleksei-grovety!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Dec 5, 2024
Copy link

pytorch-bot bot commented Dec 5, 2024

Please seek CI approval before scheduling CIFlow labels

@freddan80
Copy link
Collaborator

Hi @Aleksei-grovety ! This needs a rebase pls

@Aleksei-grovety Aleksei-grovety force-pushed the fix-repeat-args-in-arm-pass branch from 62a2493 to a378621 Compare December 10, 2024 17:20
@Aleksei-grovety
Copy link
Author

Hi @Aleksei-grovety ! This needs a rebase pls

Hi! Thanks for the advice. Done.

In the ConvertExpandCopyToRepeatPass the arguments for the repeat operation are formed incorrectly.
For the torch.Tensor.expand operation passing -1 as the size for a dimension means that the size of that dimension does not change.
For the DeiT-tiny case, torch.ones(1, 1, 192).expand(1, -1, -1) the pass will prepare arguments to the repeat operation as [1, -1, 1] which will cause an error, in this case the arguments should be [1, 1, 1].
@Aleksei-grovety Aleksei-grovety force-pushed the fix-repeat-args-in-arm-pass branch from a378621 to 4d8a7e4 Compare December 11, 2024 11:13
@freddan80
Copy link
Collaborator

Thx @Aleksei-grovety! There seem to be a general issue in the CI. See #7285 (comment)
Working on it...

@freddan80
Copy link
Collaborator

There's two issues. 1) that you saw in your last log had to do with docker images being push ahead of PR merge. That should be resolved now. 2) this: #7285 (comment)

@freddan80
Copy link
Collaborator

@Aleksei-grovety sorry, you need to rebase again for the tests to pass :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants