[executorch][emitter] Emit FQNs #7192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emit FQNs for external tensors. In the emitter, store external tensors as:
```
// list of unique tensors
external_constants_buffer: List[bytes]
// map of {constant_tag: {fqn: index into external_constant_buffer}}
// constant_tag: may want to save multiple external constant files; group them together via the tag.
// {fqn: index}; there may be multiple fqns pointing to the same data buffer. This is for deduplication.
external_constants_map: [Dict[str, Dict[str, int]]
```
Differential Revision: [D66523226](https://our.internmc.facebook.com/intern/diff/D66523226/)
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7192
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit aa64067 with merge base b9db0a3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66523226 |
This was referenced Dec 5, 2024
Emit FQNs for external tensors. In the emitter, store external tensors as:
```
// list of unique tensors
external_constants_buffer: List[bytes]
// map of {constant_tag: {fqn: index into external_constant_buffer}}
// constant_tag: may want to save multiple external constant files; group them together via the tag.
// {fqn: index}; there may be multiple fqns pointing to the same data buffer. This is for deduplication.
external_constants_map: [Dict[str, Dict[str, int]]
```
Differential Revision: [D66523226](https://our.internmc.facebook.com/intern/diff/D66523226/)
[ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66523226 |
JacobSzwejbka
approved these changes
Dec 7, 2024
Emit FQNs for external tensors. In the emitter, store external tensors as:
```
// list of unique tensors
external_constants_buffer: List[bytes]
// map of {constant_tag: {fqn: index into external_constant_buffer}}
// constant_tag: may want to save multiple external constant files; group them together via the tag.
// {fqn: index}; there may be multiple fqns pointing to the same data buffer. This is for deduplication.
external_constants_map: [Dict[str, Dict[str, int]]
```
Differential Revision: [D66523226](https://our.internmc.facebook.com/intern/diff/D66523226/)
[ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Dec 7, 2024
Pull Request resolved: #7192 Emit FQNs for external tensors. In the emitter, store external tensors as: ``` // list of unique tensors external_constants_buffer: List[bytes] // map of {constant_tag: {fqn: index into external_constant_buffer}} // constant_tag: may want to save multiple external constant files; group them together via the tag. // {fqn: index}; there may be multiple fqns pointing to the same data buffer. This is for deduplication. external_constants_map: [Dict[str, Dict[str, int]] ``` ghstack-source-id: 257035393 @exported-using-ghexport Differential Revision: [D66523226](https://our.internmc.facebook.com/intern/diff/D66523226/)
|
This pull request was exported from Phabricator. Differential Revision: D66523226 |
Emit FQNs for external tensors. In the emitter, store external tensors as:
```
// list of unique tensors
external_constants_buffer: List[bytes]
// map of {constant_tag: {fqn: index into external_constant_buffer}}
// constant_tag: may want to save multiple external constant files; group them together via the tag.
// {fqn: index}; there may be multiple fqns pointing to the same data buffer. This is for deduplication.
external_constants_map: [Dict[str, Dict[str, int]]
```
Differential Revision: [D66523226](https://our.internmc.facebook.com/intern/diff/D66523226/)
[ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Dec 9, 2024
Pull Request resolved: #7192 Emit FQNs for external tensors. In the emitter, store external tensors as: ``` // list of unique tensors external_constants_buffer: List[bytes] // map of {constant_tag: {fqn: index into external_constant_buffer}} // constant_tag: may want to save multiple external constant files; group them together via the tag. // {fqn: index}; there may be multiple fqns pointing to the same data buffer. This is for deduplication. external_constants_map: [Dict[str, Dict[str, int]] ``` ghstack-source-id: 257245125 @exported-using-ghexport Differential Revision: [D66523226](https://our.internmc.facebook.com/intern/diff/D66523226/)
|
This pull request was exported from Phabricator. Differential Revision: D66523226 |
This was referenced Dec 9, 2024
facebook-github-bot
merged commit 2adf86f
into
gh/lucylq/19/base
44 of 46 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Dec 10, 2024
Pull Request resolved: #7192 Emit FQNs for external tensors. In the emitter, store external tensors as: ``` // list of unique tensors external_constants_buffer: List[bytes] // map of {constant_tag: {fqn: index into external_constant_buffer}} // constant_tag: may want to save multiple external constant files; group them together via the tag. // {fqn: index}; there may be multiple fqns pointing to the same data buffer. This is for deduplication. external_constants_map: [Dict[str, Dict[str, int]] ``` ghstack-source-id: 257245125 @exported-using-ghexport Differential Revision: [D66523226](https://our.internmc.facebook.com/intern/diff/D66523226/) Co-authored-by: lucylq <[email protected]>
This was referenced Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Emit FQNs for external tensors. In the emitter, store external tensors as:
Differential Revision: D66523226