[executorch][schema] Add 'EXTERNAL' to DataLocation in schema #7191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To indicate if a tensor is external to the PTE file or not. Currently, we can also use the existence of 'fqn' to determine if a tensor is external or not. I think it's better to have a specific location field as fqn may be required for cases besides external tensor storage. Differential Revision: [D66523171](https://our.internmc.facebook.com/intern/diff/D66523171/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7191
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 5c5b700 with merge base 538bfaf ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66523171 |
This was referenced Dec 5, 2024
…ema" To indicate if a tensor is external to the PTE file or not. Currently, we can also use the existence of 'fqn' to determine if a tensor is external or not. I think it's better to have a specific location field as fqn may be required for cases besides external tensor storage. Differential Revision: [D66523171](https://our.internmc.facebook.com/intern/diff/D66523171/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Dec 6, 2024
Pull Request resolved: #7191 To indicate if a tensor is external to the PTE file or not. Currently, we can also use the existence of 'fqn' to determine if a tensor is external or not. I think it's better to have a specific location field as fqn may be required for cases besides external tensor storage. ghstack-source-id: 256944021 @exported-using-ghexport Differential Revision: [D66523171](https://our.internmc.facebook.com/intern/diff/D66523171/)
|
This pull request was exported from Phabricator. Differential Revision: D66523171 |
…ema" To indicate if a tensor is external to the PTE file or not. Currently, we can also use the existence of 'fqn' to determine if a tensor is external or not. I think it's better to have a specific location field as fqn may be required for cases besides external tensor storage. Differential Revision: [D66523171](https://our.internmc.facebook.com/intern/diff/D66523171/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Dec 6, 2024
Pull Request resolved: #7191 To indicate if a tensor is external to the PTE file or not. Currently, we can also use the existence of 'fqn' to determine if a tensor is external or not. I think it's better to have a specific location field as fqn may be required for cases besides external tensor storage. ghstack-source-id: 256953748 @exported-using-ghexport Differential Revision: [D66523171](https://our.internmc.facebook.com/intern/diff/D66523171/)
|
This pull request was exported from Phabricator. Differential Revision: D66523171 |
JacobSzwejbka
approved these changes
Dec 6, 2024
…ema" To indicate if a tensor is external to the PTE file or not. Currently, we can also use the existence of 'fqn' to determine if a tensor is external or not. I think it's better to have a specific location field as fqn may be required for cases besides external tensor storage. Differential Revision: [D66523171](https://our.internmc.facebook.com/intern/diff/D66523171/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66523171 |
…ema" To indicate if a tensor is external to the PTE file or not. Currently, we can also use the existence of 'fqn' to determine if a tensor is external or not. I think it's better to have a specific location field as fqn may be required for cases besides external tensor storage. Differential Revision: [D66523171](https://our.internmc.facebook.com/intern/diff/D66523171/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Dec 6, 2024
Pull Request resolved: #7191 To indicate if a tensor is external to the PTE file or not. Currently, we can also use the existence of 'fqn' to determine if a tensor is external or not. I think it's better to have a specific location field as fqn may be required for cases besides external tensor storage. ghstack-source-id: 256993560 @exported-using-ghexport Differential Revision: [D66523171](https://our.internmc.facebook.com/intern/diff/D66523171/)
|
This pull request was exported from Phabricator. Differential Revision: D66523171 |
…ema" To indicate if a tensor is external to the PTE file or not. Currently, we can also use the existence of 'fqn' to determine if a tensor is external or not. I think it's better to have a specific location field as fqn may be required for cases besides external tensor storage. Differential Revision: [D66523171](https://our.internmc.facebook.com/intern/diff/D66523171/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Dec 7, 2024
Pull Request resolved: #7191 To indicate if a tensor is external to the PTE file or not. Currently, we can also use the existence of 'fqn' to determine if a tensor is external or not. I think it's better to have a specific location field as fqn may be required for cases besides external tensor storage. ghstack-source-id: 257019860 @exported-using-ghexport Differential Revision: [D66523171](https://our.internmc.facebook.com/intern/diff/D66523171/)
|
This pull request was exported from Phabricator. Differential Revision: D66523171 |
…ema" To indicate if a tensor is external to the PTE file or not. Currently, we can also use the existence of 'fqn' to determine if a tensor is external or not. I think it's better to have a specific location field as fqn may be required for cases besides external tensor storage. Differential Revision: [D66523171](https://our.internmc.facebook.com/intern/diff/D66523171/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Dec 7, 2024
Pull Request resolved: #7191 To indicate if a tensor is external to the PTE file or not. Currently, we can also use the existence of 'fqn' to determine if a tensor is external or not. I think it's better to have a specific location field as fqn may be required for cases besides external tensor storage. ghstack-source-id: 257025805 @exported-using-ghexport Differential Revision: [D66523171](https://our.internmc.facebook.com/intern/diff/D66523171/)
|
This pull request was exported from Phabricator. Differential Revision: D66523171 |
dbort
approved these changes
Dec 7, 2024
…ema" To indicate if a tensor is external to the PTE file or not. Currently, we can also use the existence of 'fqn' to determine if a tensor is external or not. I think it's better to have a specific location field as fqn may be required for cases besides external tensor storage. Differential Revision: [D66523171](https://our.internmc.facebook.com/intern/diff/D66523171/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Dec 7, 2024
Pull Request resolved: #7191 To indicate if a tensor is external to the PTE file or not. Currently, we can also use the existence of 'fqn' to determine if a tensor is external or not. I think it's better to have a specific location field as fqn may be required for cases besides external tensor storage. ghstack-source-id: 257035024 @exported-using-ghexport Differential Revision: [D66523171](https://our.internmc.facebook.com/intern/diff/D66523171/)
|
This pull request was exported from Phabricator. Differential Revision: D66523171 |
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Dec 9, 2024
Pull Request resolved: #7191 To indicate if a tensor is external to the PTE file or not. Currently, we can also use the existence of 'fqn' to determine if a tensor is external or not. I think it's better to have a specific location field as fqn may be required for cases besides external tensor storage. ghstack-source-id: 257035024 @exported-using-ghexport Differential Revision: [D66523171](https://our.internmc.facebook.com/intern/diff/D66523171/) Co-authored-by: lucylq <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
To indicate if a tensor is external to the PTE file or not.
Currently, we can also use the existence of 'fqn' to determine if a tensor is external or not.
I think it's better to have a specific location field as fqn may be required for cases besides external tensor storage.
Differential Revision: D66523171