Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce executorch_ops_check #7142

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

larryliu0820
Copy link
Contributor

Summary: Introducing executorch_ops_check. For any given target, find all the executorch_generated_lib targets in the dependent transitive closure and make sure the operators in executorch_generated_lib are not overlapping.

Differential Revision: D66560425

Copy link

pytorch-bot bot commented Dec 2, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7142

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 148c53a with merge base 5a9e7a4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 2, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66560425

Copy link
Contributor

@lucylq lucylq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! note linter failure

facebook-github-bot pushed a commit that referenced this pull request Dec 3, 2024
Summary:

Introducing `executorch_ops_check`. For any given target, find all the `executorch_generated_lib` targets in the dependent transitive closure and make sure the operators in `executorch_generated_lib` are not overlapping.

Reviewed By: lucylq

Differential Revision: D66560425
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66560425

facebook-github-bot pushed a commit that referenced this pull request Dec 3, 2024
Summary:

Introducing `executorch_ops_check`. For any given target, find all the `executorch_generated_lib` targets in the dependent transitive closure and make sure the operators in `executorch_generated_lib` are not overlapping.

Reviewed By: lucylq

Differential Revision: D66560425
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66560425

facebook-github-bot pushed a commit that referenced this pull request Dec 3, 2024
Summary:

Introducing `executorch_ops_check`. For any given target, find all the `executorch_generated_lib` targets in the dependent transitive closure and make sure the operators in `executorch_generated_lib` are not overlapping.

Reviewed By: lucylq

Differential Revision: D66560425
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66560425

facebook-github-bot pushed a commit that referenced this pull request Dec 3, 2024
Summary:

Introducing `executorch_ops_check`. For any given target, find all the `executorch_generated_lib` targets in the dependent transitive closure and make sure the operators in `executorch_generated_lib` are not overlapping.

Reviewed By: lucylq

Differential Revision: D66560425
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66560425

Summary:

Introducing `executorch_ops_check`. For any given target, find all the `executorch_generated_lib` targets in the dependent transitive closure and make sure the operators in `executorch_generated_lib` are not overlapping.

Reviewed By: lucylq

Differential Revision: D66560425
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66560425

@facebook-github-bot facebook-github-bot merged commit 8497cba into main Dec 3, 2024
40 of 43 checks passed
@facebook-github-bot facebook-github-bot deleted the export-D66560425 branch December 3, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants