Removed unnecessary conditions in op_add and op_mul #7135
Conversation
Added scalar function call in op_add and op_mul Updated undefining of macros in op_quantize Updated elseif() instead of if() in op_cat Signed-off-by: [email protected] <[email protected]>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7135
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0ef057f with merge base 2d499b3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
| @@ -37,6 +34,7 @@ Tensor& cat_out( | |||
| exec_aten::ArrayRef<Tensor> tensors, | |||
| int64_t dim, | |||
| Tensor& out) { | |||
|
|
|||
There was a problem hiding this comment.
please remove new line to make linter happy
| @@ -565,6 +565,7 @@ Tensor& quantize_per_tensor_out( | |||
| int64_t quant_max, | |||
| ScalarType dtype, | |||
| Tensor& out) { | |||
|
|
|||
There was a problem hiding this comment.
please remove new line to make linter happy
| @@ -802,6 +802,6 @@ Tensor& quantize_per_token_out( | |||
| } | |||
|
|
|||
| } // namespace native | |||
| } // namespace FusionG3 | |||
| } // namespace G3 | |||
| } // namespace impl | |||
| } // namespace cadence | |||
There was a problem hiding this comment.
Nit: missing new line at end of file
There was a problem hiding this comment.
Nit: missing new line at end of file
All the operator files do not have a new line at the end. Not having a new line at the end is not shown as linter error.
|
lgtm, same comment as Matthias :) |
Signed-off-by: [email protected] <[email protected]>
|
@mcremon-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary:
Added scalar function call in op_add and op_mul
Updated undefining of macros in op_quantize
Updated elseif() instead of if() in op_cat