Implement get_freqs for RopeWithAttentionSink #7100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR implements the `get_freqs` function for `RopeWithAttentionSink`. It returns the `freqs_cos` and `freqs_sin` for given `input_pos` and `seq_len` after shifting tokens in the pre-computed `freqs_cos` and `freq_sin`. Differential Revision: [D66525306](https://our.internmc.facebook.com/intern/diff/D66525306/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7100
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9d1ab6f with merge base b8fbc48 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66525306 |
This was referenced Nov 27, 2024
Merged
larryliu0820
approved these changes
Nov 27, 2024
helunwencser
added
the
release notes:attention_sink
facebook-github-bot
merged commit a0f577a
into
gh/helunwencser/81/base
41 of 46 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Nov 27, 2024
This PR implements the `get_freqs` function for `RopeWithAttentionSink`. It returns the `freqs_cos` and `freqs_sin` for given `input_pos` and `seq_len` after shifting tokens in the pre-computed `freqs_cos` and `freq_sin`. Differential Revision: [D66525306](https://our.internmc.facebook.com/intern/diff/D66525306/) ghstack-source-id: 255582545 Pull Request resolved: #7100
kirklandsign
pushed a commit
that referenced
this pull request
Nov 27, 2024
This PR implements the `get_freqs` function for `RopeWithAttentionSink`. It returns the `freqs_cos` and `freqs_sin` for given `input_pos` and `seq_len` after shifting tokens in the pre-computed `freqs_cos` and `freq_sin`. Differential Revision: [D66525306](https://our.internmc.facebook.com/intern/diff/D66525306/) ghstack-source-id: 255582545 Pull Request resolved: #7100 Co-authored-by: Lunwen He <[email protected]>
mergennachin
pushed a commit
that referenced
this pull request
Dec 2, 2024
This PR implements the `get_freqs` function for `RopeWithAttentionSink`. It returns the `freqs_cos` and `freqs_sin` for given `input_pos` and `seq_len` after shifting tokens in the pre-computed `freqs_cos` and `freq_sin`. Differential Revision: [D66525306](https://our.internmc.facebook.com/intern/diff/D66525306/) ghstack-source-id: 255582545 Pull Request resolved: #7100 Co-authored-by: Lunwen He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR implements the
get_freqsfunction forRopeWithAttentionSink. It returns thefreqs_cosandfreqs_sinfor giveninput_posandseq_lenafter shifting tokens in the pre-computedfreqs_cosandfreq_sin.Differential Revision: D66525306