Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llama-mm] Onboard torchtune vision encoder to ExecuTorch/AOTI #6807

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

larryliu0820
Copy link
Contributor

@larryliu0820 larryliu0820 commented Nov 13, 2024

Stack from ghstack (oldest at bottom):

Summary: As titled. This PR adds llama3_2_vision_encoder to
examples/models/llama3_2_vision/vision_encoder and add CI jobs.

Test Plan: Rely on newly added CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:

Summary: As titled. This PR adds `llama3_2_vision_encoder` to
`examples/models/llama3_2_vision/vision_encoder` and add CI jobs.

Test Plan: Rely on newly added CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Nov 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6807

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 92fc8e7 with merge base f943856 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

larryliu0820 added a commit that referenced this pull request Nov 13, 2024
Summary: As titled. This PR adds `llama3_2_vision_encoder` to
`examples/models/llama3_2_vision/vision_encoder` and add CI jobs.

Test Plan: Rely on newly added CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 3986ad8fdafdedce60edeac11ebd07c46d963522
Pull Request resolved: #6807
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 13, 2024
@larryliu0820 larryliu0820 changed the title [llama-mm] Onboard torchtune vision encoder to ExecuTorch [llama-mm] Onboard torchtune vision encoder to ExecuTorch/AOTI Nov 13, 2024
…AOTI"

Summary: As titled. This PR adds `llama3_2_vision_encoder` to
`examples/models/llama3_2_vision/vision_encoder` and add CI jobs.

Test Plan: Rely on newly added CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Nov 13, 2024
Summary: As titled. This PR adds `llama3_2_vision_encoder` to
`examples/models/llama3_2_vision/vision_encoder` and add CI jobs.

Test Plan: Rely on newly added CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 233a7366f222b9796f8fcdbe52a0e4440b870685
Pull Request resolved: #6807
@larryliu0820 larryliu0820 merged commit a6cfb03 into gh/larryliu0820/58/base Nov 13, 2024
63 of 65 checks passed
@larryliu0820 larryliu0820 deleted the gh/larryliu0820/58/head branch November 13, 2024 19:36
larryliu0820 added a commit that referenced this pull request Nov 13, 2024
@larryliu0820
Copy link
Contributor Author

@pytorchbot cherry-pick main

Copy link

pytorch-bot bot commented Nov 13, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: the following arguments are required: --onto, -c/--classification

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@larryliu0820
Copy link
Contributor Author

@pytorchbot cherry-pick --onto main

Copy link

pytorch-bot bot commented Nov 13, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: the following arguments are required: -c/--classification

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@larryliu0820
Copy link
Contributor Author

@pytorchbot cherry-pick --onto main -c critical

pytorchbot pushed a commit that referenced this pull request Nov 13, 2024
[llama-mm] Onboard torchtune vision encoder to ExecuTorch

Summary: As titled. This PR adds `llama3_2_vision_encoder` to
`examples/models/llama3_2_vision/vision_encoder` and add CI jobs.

Test Plan: Rely on newly added CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]

(cherry picked from commit a6cfb03)
@pytorchbot
Copy link
Collaborator

Cherry picking #6807

The cherry pick PR is at #6831 and it is recommended to link a critical cherry pick PR with an issue.

Details for Dev Infra team Raised by workflow job

larryliu0820 added a commit that referenced this pull request Nov 13, 2024
[llama-mm] Onboard torchtune vision encoder to ExecuTorch

Summary: As titled. This PR adds `llama3_2_vision_encoder` to
`examples/models/llama3_2_vision/vision_encoder` and add CI jobs.

Test Plan: Rely on newly added CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]

(cherry picked from commit a6cfb03)
larryliu0820 added a commit that referenced this pull request Nov 13, 2024
* [llama-mm] Onboard torchtune vision encoder to ExecuTorch/AOTI (#6807)

[llama-mm] Onboard torchtune vision encoder to ExecuTorch

Summary: As titled. This PR adds `llama3_2_vision_encoder` to
`examples/models/llama3_2_vision/vision_encoder` and add CI jobs.

Test Plan: Rely on newly added CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]

(cherry picked from commit a6cfb03)

* Fix tests

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Move manual_seed() into setUp

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

---------

Co-authored-by: Mengwei Liu <[email protected]>
Co-authored-by: Mengwei Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants