Fix missing move and bare new in pytree from_str_internal #6783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a couple minor fixes. Differential Revision: [D65576543](https://our.internmc.facebook.com/intern/diff/D65576543/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6783
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit b2d6a4c with merge base dc41596 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
swolchok
added a commit
that referenced
this pull request
Nov 12, 2024
Just a couple minor fixes. Differential Revision: [D65576543](https://our.internmc.facebook.com/intern/diff/D65576543/) ghstack-source-id: 253128072 Pull Request resolved: #6783
|
This pull request was exported from Phabricator. Differential Revision: D65576543 |
|
Had to re-export this one because I landed it wrong when it was #6702; apparently I am supposed to click the internal land button. |
lucylq
approved these changes
Nov 12, 2024
|
extension/llm/modules/test/test_mha.py::AttentionTest::test_attention_executorch seems to be flaky -- https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50&name_filter=unittest&mergeLF=true . bypassing |
swolchok
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
swolchok
added a commit
that referenced
this pull request
Nov 12, 2024
* Use std::variant to implement pytree Key Pull Request resolved: #6701 Key was a struct that should've been a union; std::variant makes using a union much easier. ghstack-source-id: 253128071 @exported-using-ghexport Differential Revision: [D65575184](https://our.internmc.facebook.com/intern/diff/D65575184/) * Fix missing move and bare new in pytree from_str_internal Just a couple minor fixes. Differential Revision: [D65576543](https://our.internmc.facebook.com/intern/diff/D65576543/) ghstack-source-id: 253128072 Pull Request resolved: #6783 --------- Co-authored-by: Scott Wolchok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Just a couple minor fixes.
Differential Revision: D65576543