Print the number of tokens generated #6771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for verifying the correctness of AttentionSink. Differential Revision: [D65784095](https://our.internmc.facebook.com/intern/diff/D65784095/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6771
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 63b070d with merge base 623a9a6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65784095 |
davidlin54
reviewed
Nov 11, 2024
| @@ -91,10 +91,11 @@ def main() -> None: | |||
| else runner.text_completion( | |||
| prompt=args.prompt, | |||
| temperature=args.temperature, | |||
| echo=True, | |||
There was a problem hiding this comment.
out of curiousity, what does echo=True do?
There was a problem hiding this comment.
When it is true, the returned token list will include prompt tokens as well.
davidlin54
approved these changes
Nov 11, 2024
This is useful for verifying the correctness of AttentionSink. Differential Revision: [D65784095](https://our.internmc.facebook.com/intern/diff/D65784095/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65784095 |
facebook-github-bot
merged commit 1a5180e
into
gh/helunwencser/75/base
39 of 41 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
lucylq
pushed a commit
that referenced
this pull request
Nov 12, 2024
Pull Request resolved: #6771 This is useful for verifying the correctness of AttentionSink. ghstack-source-id: 252993225 @exported-using-ghexport Differential Revision: [D65784095](https://our.internmc.facebook.com/intern/diff/D65784095/) Co-authored-by: Lunwen He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This is useful for verifying the correctness of AttentionSink.
Differential Revision: D65784095