Add NOSTDINC and NOTORCHINC lintrunner #6693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prohibit standard C++ container, aten, and torch includes in core, at least pending further review. Note that non-core directories, such as extension/, test/, and any testing_util/ subdirectories, are exempted. Differential Revision: [D65541332](https://our.internmc.facebook.com/intern/diff/D65541332/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6693
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit f862761 with merge base dc41596 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
swolchok
added a commit
that referenced
this pull request
Nov 6, 2024
Prohibit standard C++ container, aten, and torch includes in core, at least pending further review. Note that non-core directories, such as extension/, test/, and any testing_util/ subdirectories, are exempted. Differential Revision: [D65541332](https://our.internmc.facebook.com/intern/diff/D65541332/) ghstack-source-id: 252107495 Pull Request resolved: #6693
|
This pull request was exported from Phabricator. Differential Revision: D65541332 |
swolchok
changed the title
kimishpatel
requested changes
Nov 7, 2024
| "**/*.h", | ||
| "**/*.hpp", | ||
| ] | ||
| exclude_patterns = [ |
There was a problem hiding this comment.
Instead of exclude, can you just do include for runtime directory?
There was a problem hiding this comment.
Instead of exclude, can you just do include for runtime directory?
directories should be linted for this unless we know that they shouldn't be. We want this to fail closed.
Prohibit standard C++ container, aten, and torch includes in core, at least pending further review. Note that non-core directories, such as extension/, test/, and any testing_util/ subdirectories, are exempted. Differential Revision: [D65541332](https://our.internmc.facebook.com/intern/diff/D65541332/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Nov 8, 2024
Pull Request resolved: #6693 Prohibit standard C++ container, aten, and torch includes in core, at least pending further review. Note that non-core directories, such as extension/, test/, and any testing_util/ subdirectories, are exempted. Differential Revision: [D65541332](https://our.internmc.facebook.com/intern/diff/D65541332/) ghstack-source-id: 252628653
|
This pull request was exported from Phabricator. Differential Revision: D65541332 |
yes see internal diff test plan |
Prohibit standard C++ container, aten, and torch includes in core, at least pending further review. Note that non-core directories, such as extension/, test/, and any testing_util/ subdirectories, are exempted. Differential Revision: [D65541332](https://our.internmc.facebook.com/intern/diff/D65541332/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Nov 12, 2024
Pull Request resolved: #6693 Prohibit standard C++ container, aten, and torch includes in core, at least pending further review. Note that non-core directories, such as extension/, test/, and any testing_util/ subdirectories, are exempted. ghstack-source-id: 253169886 Differential Revision: [D65541332](https://our.internmc.facebook.com/intern/diff/D65541332/)
|
This pull request was exported from Phabricator. Differential Revision: D65541332 |
Prohibit standard C++ container, aten, and torch includes in core, at least pending further review. Note that non-core directories, such as extension/, test/, and any testing_util/ subdirectories, are exempted. Differential Revision: [D65541332](https://our.internmc.facebook.com/intern/diff/D65541332/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Nov 12, 2024
Pull Request resolved: #6693 Prohibit standard C++ container, aten, and torch includes in core, at least pending further review. Note that non-core directories, such as extension/, test/, and any testing_util/ subdirectories, are exempted. ghstack-source-id: 253193810 Differential Revision: [D65541332](https://our.internmc.facebook.com/intern/diff/D65541332/)
|
This pull request was exported from Phabricator. Differential Revision: D65541332 |
mergennachin
approved these changes
Nov 12, 2024
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
swolchok
added a commit
that referenced
this pull request
Nov 13, 2024
[ExecuTorch] Add NOSTDINC and NOTORCHINC lintrunner Pull Request resolved: #6693 Prohibit standard C++ container, aten, and torch includes in core, at least pending further review. Note that non-core directories, such as extension/, test/, and any testing_util/ subdirectories, are exempted. ghstack-source-id: 253193810 Differential Revision: [D65541332](https://our.internmc.facebook.com/intern/diff/D65541332/) Co-authored-by: Scott Wolchok <[email protected]>
swolchok
added a commit
that referenced
this pull request
Nov 13, 2024
* [ExecuTorch] Remove PATTERNLINT suppressions Pull Request resolved: #6692 The linter these are suppressing was removed in D63859186. ghstack-source-id: 253169885 Differential Revision: [D65507718](https://our.internmc.facebook.com/intern/diff/D65507718/) * Add NOSTDINC and NOTORCHINC lintrunner (#6822) [ExecuTorch] Add NOSTDINC and NOTORCHINC lintrunner Pull Request resolved: #6693 Prohibit standard C++ container, aten, and torch includes in core, at least pending further review. Note that non-core directories, such as extension/, test/, and any testing_util/ subdirectories, are exempted. ghstack-source-id: 253193810 Differential Revision: [D65541332](https://our.internmc.facebook.com/intern/diff/D65541332/) Co-authored-by: Scott Wolchok <[email protected]> --------- Co-authored-by: Scott Wolchok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Prohibit standard C++ container, aten, and torch includes in core, at least pending further review. Note that non-core directories, such as extension/, test/, and any testing_util/ subdirectories, are exempted.
Differential Revision: D65541332