From fe40477e0571daf981b74eb54fb2be0484570530 Mon Sep 17 00:00:00 2001 From: Scott Wolchok Date: Wed, 6 Nov 2024 08:32:07 -0800 Subject: [PATCH] [ExecuTorch] Remove PATTERNLINT suppressions The linter these are suppressing was removed in D63859186. Differential Revision: [D65507718](https://our.internmc.facebook.com/intern/diff/D65507718/) [ghstack-poisoned] --- extension/llm/custom_ops/op_sdpa.cpp | 1 - extension/llm/runner/image.h | 1 - extension/llm/runner/multimodal_runner.h | 3 --- extension/llm/runner/stats.h | 1 - extension/llm/runner/text_decoder_runner.h | 1 - extension/llm/runner/text_prefiller.h | 1 - extension/llm/tokenizer/tokenizer.h | 2 -- extension/parallel/thread_parallel.h | 1 - kernels/optimized/vec/vec_base.h | 2 -- runtime/core/exec_aten/testing_util/tensor_factory.h | 2 -- 10 files changed, 15 deletions(-) diff --git a/extension/llm/custom_ops/op_sdpa.cpp b/extension/llm/custom_ops/op_sdpa.cpp index 8afec156d5..50fa933833 100644 --- a/extension/llm/custom_ops/op_sdpa.cpp +++ b/extension/llm/custom_ops/op_sdpa.cpp @@ -16,7 +16,6 @@ #include #include -// patternlint-disable-next-line executorch-cpp-nostdinc #include #ifdef ET_USE_THREADPOOL diff --git a/extension/llm/runner/image.h b/extension/llm/runner/image.h index d3c4e8d945..308bd87444 100644 --- a/extension/llm/runner/image.h +++ b/extension/llm/runner/image.h @@ -10,7 +10,6 @@ #pragma once #include -// patternlint-disable-next-line executorch-cpp-nostdinc #include #include diff --git a/extension/llm/runner/multimodal_runner.h b/extension/llm/runner/multimodal_runner.h index 1af9cb6fa2..94539c65cc 100644 --- a/extension/llm/runner/multimodal_runner.h +++ b/extension/llm/runner/multimodal_runner.h @@ -13,13 +13,10 @@ #pragma once #include -// patternlint-disable-next-line executorch-cpp-nostdinc #include #include -// patternlint-disable-next-line executorch-cpp-nostdinc #include #include -// patternlint-disable-next-line executorch-cpp-nostdinc #include #include diff --git a/extension/llm/runner/stats.h b/extension/llm/runner/stats.h index f9462d24cd..79c5781e33 100644 --- a/extension/llm/runner/stats.h +++ b/extension/llm/runner/stats.h @@ -12,7 +12,6 @@ #include #include #include -// patternlint-disable-next-line executorch-cpp-nostdinc #include namespace executorch { diff --git a/extension/llm/runner/text_decoder_runner.h b/extension/llm/runner/text_decoder_runner.h index c6f8a0ca67..ca4d127e51 100644 --- a/extension/llm/runner/text_decoder_runner.h +++ b/extension/llm/runner/text_decoder_runner.h @@ -14,7 +14,6 @@ #include #include #include -// patternlint-disable-next-line executorch-cpp-nostdinc #include namespace executorch { diff --git a/extension/llm/runner/text_prefiller.h b/extension/llm/runner/text_prefiller.h index 9dbaec40e6..2f1d5ae2b7 100644 --- a/extension/llm/runner/text_prefiller.h +++ b/extension/llm/runner/text_prefiller.h @@ -13,7 +13,6 @@ #include #include -// patternlint-disable-next-line executorch-cpp-nostdinc #include namespace executorch { diff --git a/extension/llm/tokenizer/tokenizer.h b/extension/llm/tokenizer/tokenizer.h index 52983d9075..c987857a30 100644 --- a/extension/llm/tokenizer/tokenizer.h +++ b/extension/llm/tokenizer/tokenizer.h @@ -9,9 +9,7 @@ #pragma once #include -// patternlint-disable-next-line executorch-cpp-nostdinc #include -// patternlint-disable-next-line executorch-cpp-nostdinc #include #include diff --git a/extension/parallel/thread_parallel.h b/extension/parallel/thread_parallel.h index bbce211597..8b174075ae 100644 --- a/extension/parallel/thread_parallel.h +++ b/extension/parallel/thread_parallel.h @@ -9,7 +9,6 @@ #pragma once #include -// @nolint PATTERNLINT Ok to use stdlib for this optional library #include namespace executorch { diff --git a/kernels/optimized/vec/vec_base.h b/kernels/optimized/vec/vec_base.h index 4a386f9e8c..5ff4327e6f 100644 --- a/kernels/optimized/vec/vec_base.h +++ b/kernels/optimized/vec/vec_base.h @@ -1,7 +1,5 @@ #pragma once -// @nolint PATTERNLINT is required for std::equal_to, etc. - #include #include #include diff --git a/runtime/core/exec_aten/testing_util/tensor_factory.h b/runtime/core/exec_aten/testing_util/tensor_factory.h index 2ea21e9583..6822feba80 100644 --- a/runtime/core/exec_aten/testing_util/tensor_factory.h +++ b/runtime/core/exec_aten/testing_util/tensor_factory.h @@ -15,9 +15,7 @@ #include #else // !USE_ATEN_LIB #include -// @nolint PATTERNLINT Ok to use stdlib for this test framework #include -// @nolint PATTERNLINT Ok to use stdlib for this test framework #include #endif // !USE_ATEN_LIB