-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[llama-mm] Onboard Llama3.2 mm vision encoder #6653
Conversation
Summary: Add llama3.2 mm vision encoder to examples/models. We need to do a module swapping for TilePositionEmbedding to make sure vision encoder is exportable. Test Plan: Unit tests. Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6653
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 7 New FailuresAs of commit c533944 with merge base 3a1f8d2 (): NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Summary: Add llama3.2 mm vision encoder to examples/models. We need to do a module swapping for TilePositionEmbedding to make sure vision encoder is exportable. Test Plan: Unit tests. Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 4c2a30e6d6b5932a972c34778fea8b3152372e58 Pull Request resolved: #6653
Summary: Add llama3.2 mm vision encoder to examples/models. We need to do a module swapping for TilePositionEmbedding to make sure vision encoder is exportable. Test Plan: Unit tests. Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Add llama3.2 mm vision encoder to examples/models. We need to do a module swapping for TilePositionEmbedding to make sure vision encoder is exportable. Test Plan: Unit tests. Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: f996a614d7ec1b4c7fa4c1cb20bdcc02d813771c Pull Request resolved: #6653
from executorch.extension.llm.modules._position_embeddings import ( | ||
replace_tile_positional_embedding, | ||
) | ||
from torchtune.models.flamingo._component_builders import flamingo_vision_encoder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to change to:
from torchtune.models.llama3_2_vision._component_builders import llama3_2_vision_encoder
Close in favor of #6831 |
Stack from ghstack (oldest at bottom):
Summary: Add llama3.2 mm vision encoder to examples/models.
We need to do a module swapping for TilePositionEmbedding to make sure
vision encoder is exportable.
Test Plan: Unit tests.
Reviewers:
Subscribers:
Tasks:
Tags: