Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo: Use AsyncFor element access in codegen #127278

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Fix typo: Use AsyncFor element access in codegen #127278

merged 1 commit into from
Nov 26, 2024

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Nov 26, 2024

Use AsyncFor instead of For for element access in codegen_async_for.
It hasn't been an issue so far as both structs have the same elements.

iritkatriel
iritkatriel approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@iritkatriel iritkatriel enabled auto-merge (squash) November 26, 2024 00:26
@cdce8p
Copy link
Contributor Author

cdce8p commented Nov 26, 2024 •
edited
Loading

@iritkatriel I believe you might need to add the skip issue label as well for auto-merge to work.

@iritkatriel iritkatriel changed the title Use AsyncFor element access in codegen Fix typo: Use AsyncFor element access in codegen Nov 26, 2024
@iritkatriel iritkatriel enabled auto-merge (squash) November 26, 2024 00:47
@iritkatriel iritkatriel merged commit 4fd9eb2 into python:main Nov 26, 2024
48 checks passed
@cdce8p cdce8p deleted the fix-async-for-codegen branch November 26, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdce8p @iritkatriel