-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-126612: Include stack effects of uops when computing maximum stack depth #126894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UOPs may want to pass values on the stack. This is currently only guaranteed to be possible if the net stack effect of the instruction is greater than the number of values that need to be passed. To ensure there is sufficient space on the stack for values passed between uops, we: 1. Compute the set of stack effects for each instruction by computing the stack effect after each uop in the instruction. 2. Collect the set of stack effects for all instructions in a family. 3. Generate a function that computes the maximum stack effect for each instruction. The maximum stack effect for a generic instruction is the maximum of all instructions in the family. 4. Use the maximum stack effect when computing the maximum stack depth of a function.
@markshannon - This is the generic solution for passing values between uops (rather than always reserving extra space on the stack) we chatted about at the last faster-cpython sync. |
iritkatriel
reviewed
Nov 20, 2024
iritkatriel
reviewed
Nov 20, 2024
markshannon
reviewed
Nov 22, 2024
This allows us to simplify the expressions
iritkatriel
reviewed
Nov 23, 2024
iritkatriel
reviewed
Nov 26, 2024
iritkatriel
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UOPs may want to pass values on the stack. This is currently only guaranteed to be possible if the net stack effect of the instruction is greater than the number of values that need to be passed.
To ensure there is sufficient space on the stack for values passed between uops, we: