Allow to configure user preferences with a configuration file #45
+84
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #37
Draft because this still needs tests, testing, and documentation (documentation probably won't be added here until this solution is accepted).
The proposed solution for storing user preferences was not approved by anyone either so that might still change too if the maintainers don't agree with my proposal.
How does this work?
Now onto how this is supposed to work... User can add a configuration file at
~/.config/cherry_picker/preferences.toml
which looks like this:Preferences override themselves in this order (the last on the list has the highest priority):
--continue
--continue
// It might perhaps make more sense to swap 2 with 3 but this order was just how I ended up implementing it so I'm just leaving it as is until I get feedback on this :)
Other notes
In issue #37, I said:
But I figured that making a TOML file is actually easier to implement and maybe faster? Using
git config
would require either using a lot of subprocess calls to get all the configuration or parsing the output ofgit config --local --list
, and its nesting support is limited to 3 levels, i.e.:which might be fine but is definitely limiting.