Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "# This file was automatically generated from ..." to generated code #27

Open
pquentin opened this issue Dec 5, 2018 · 4 comments

Comments

@pquentin
Copy link
Member

pquentin commented Dec 5, 2018

This was originally python-trio/hip#35

@pquentin
Copy link
Member Author

One issue about this is that it's going to change all line numbers by one, which will impair debugging because it makes it harder to read sync tracebacks as if they were from the async code.

Since those generated files only end up in the installed package, is it important to add this comment? I'm not sure.

@cdeler
Copy link

cdeler commented Oct 9, 2020

@pquentin

If the issue is actual: why not to add this lines at the end of the file? It would keep the line numbers...

@pquentin
Copy link
Member Author

pquentin commented Oct 9, 2020

@cdeler I can confirm now that keeping the line numbers is really important.

Adding this comment at the end is an interesting idea! I'm not sure who's going to see a line added at the bottom, but it doesn't hurt.

I'd accept a pull request that does that.

Thank you for your comment.

@cdeler
Copy link

cdeler commented Oct 9, 2020

Let me try :-) It sounds interesting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants