-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark pure reformatting PRs in .git-blame-ignore-revs #2837
Comments
I don't think so, because it'll use the current timestamp. Is there anything you think should get ignored? I looked at the blame for the abc file and the only ones I see are at least 4 years old. |
I feel like it should be possible with some post-merge github action or something, but probs not worth setting up anything overly complicated.
Did a quick look and there's a bunch of recent PR's that are somewhat borderline, like #2930 and #2932. #2823 has a mix of blocks of reformatting and other stuff. If we really wanted to we could split partial-reformatting PR's into two commits that we merge onto master, ignoring one of them, instead of squashing. |
This is mostly relevant to @CoolCat467 as you're in the progress of cleaning up the repository, but I realize we in general haven't been great at keeping that file updated.
See discussion in #2686 and #2692
It would be great if one could have a check that warned about this ... but I have no clue how that would work in any way, and I'm also not sure if it's possible to learn the commit ID's before merging such that you can actually add a PR to the file before it gets merged.
The text was updated successfully, but these errors were encountered: