Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design: how to handle async generator gc callbacks #23

Closed
njsmith opened this issue Jan 22, 2017 · 2 comments
Closed

Design: how to handle async generator gc callbacks #23

njsmith opened this issue Jan 22, 2017 · 2 comments
Labels
design discussion

Comments

@njsmith
Copy link
Member

njsmith commented Jan 22, 2017

My inclination is to only register if it lets us print some useful message like "stop depending on the gc callbacks"? Not sure what this would look like exactly.
@njsmith
Copy link
Member Author

njsmith commented Feb 22, 2017 •
edited
Loading

Dave had a great idea here which we should absolutely steal: the aclosing-context-manager-or-equivalent should make a note of the async generators passed to it, and then the hooks are used to error out if someone tries to use an async generator unsafely.

@njsmith
Copy link
Member Author

njsmith commented Aug 19, 2017

Whoops, #265 is a duplicate and has more info/discussion, so closing this in favor of that.

@njsmith njsmith closed this as completed Aug 19, 2017
encukou added a commit to encukou/trio that referenced this issue Dec 24, 2017
@encukou
Correct issue link in design docs
b912c06 
Issue python-trio#23 was closed as a duplicate of python-trio#265.
Have the docs link to the open issue.
@encukou encukou mentioned this issue Dec 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@njsmith