Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use trio.CancelScope instead of deprecated trio.open_cancel_scope #80

Closed
wants to merge 2 commits into from

Conversation

rnovatorov
Copy link

Fixes corresponding TrioDeprecationWarning.

 - Use `trio.CancelScope` instead of `trio.open_cancel_scope`
@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #80 into master will decrease coverage by 0.22%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   99.78%   99.56%   -0.23%     
==========================================
  Files          19       19              
  Lines         476      461      -15     
  Branches       41       43       +2     
==========================================
- Hits          475      459      -16     
- Misses          1        2       +1
Impacted Files Coverage Δ
pytest_trio/_tests/test_fixture_ordering.py 100% <ø> (ø) ⬆️
pytest_trio/plugin.py 98.94% <100%> (-0.54%) ⬇️
pytest_trio/_tests/test_hypothesis_interaction.py 100% <0%> (ø) ⬆️

@Zac-HD
Copy link
Member

Zac-HD commented Feb 12, 2019

Closed by #73.

@Zac-HD Zac-HD closed this Feb 12, 2019
@njsmith
Copy link
Member

njsmith commented Feb 12, 2019

Oh whoops, it looks like #73 included these fixes already, so now that I updated the PR by merging from master, the changes tab is now totally empty. Guess that means we can close this... thank you though, it was a good PR :-).

We should do a release...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants