Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transform-async-generator-decorators should affect ASYNC101 as well as ASYNC900 #315

Closed
Zac-HD opened this issue Nov 14, 2024 · 0 comments · Fixed by #316
Closed

transform-async-generator-decorators should affect ASYNC101 as well as ASYNC900 #315

Zac-HD opened this issue Nov 14, 2024 · 0 comments · Fixed by #316
Assignees
Labels
enhancement New feature or request

Comments

@Zac-HD
Copy link
Member

Zac-HD commented Nov 14, 2024

since listing a decorator claims that it's safe, we should believe the user.

As it happens I just found a case where the transform decorator in python-trio/trio#638 isn't fully safe (it can hang indefinitely on early exit)... I think the solution to that is to upstream a working version into Trio rather than continuing to have them proliferate with bugs, and so we'll presumably expand the default allowlist with that once (if?) my upcoming PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants