fix: hostname format check on empty string raises ValueError #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing hostname format check on empty string seems to raise a ValueError:
>>> from jsonschema.validators import validator_for
>>> schema = {"$schema": "https://json-schema.org/draft/2020-12/schema", "type": "string", "format": "hostname"}
>>> vcls = validator_for(schema)
>>> validator = vcls(schema, format_checker=vcls.FORMAT_CHECKER)
>>> list(validator.iter_errors(""))
...
File "lib/python3.10/site-packages/jsonschema/_format.py", line 276, in is_host_name
return FQDN(instance).is_valid
File "lib/python3.10/site-packages/fqdn/__init__.py", line 44, in __init__
raise ValueError("fqdn must be str")
ValueError: fqdn must be str
Fix by adding `raises=ValueError` to the related `@_checks_drafts` decorator call.
See also json-schema-org/JSON-Schema-Test-Suite#677.
Fixes python-jsonschema#1121.
|
I don't have time to work on this right now. Pending on discussion and decisions on JSON-Schema-Test-Suite. Regardless of what the tests check, maybe this should be included in the simple original form: add |
|
Changed from Draft to Ready, as this fixes the crash. Leaving JSON-Schema-Test-Suite modifications for people more familiar with that project and the actual (meta) schema related work. |
|
All fine. I'm going to close this then as I wouldn't merge it without tests, but you or anyone is welcome to pick it up again when the upstream PR in the test suite is merged. Thanks for the efforts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing hostname format check on empty string seems to raise a ValueError:
Fix by adding
raises=ValueErrorto the related@_checks_draftsdecorator call.See also json-schema-org/JSON-Schema-Test-Suite#677.
Fixes #1121.
📚 Documentation preview 📚: https://python-jsonschema--1127.org.readthedocs.build/en/1127/