Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branding cog - RuntimeError: Failed to fetch file due to status: 503 #2808

Open
sentry-io bot opened this issue Nov 9, 2023 · 1 comment · May be fixed by #3182
Open

Branding cog - RuntimeError: Failed to fetch file due to status: 503 #2808

sentry-io bot opened this issue Nov 9, 2023 · 1 comment · May be fixed by #3182
Assignees
@kwzrd

Comments

@sentry-io
Copy link

sentry-io bot commented Nov 9, 2023 •
edited by ChrisLovering
Loading

Sentry Issue: BOT-3MY

RuntimeError: Failed to fetch file due to status: 503
  File "bot/exts/backend/branding/_repository.py", line 204, in get_events
    instance = await self.construct_event(event_directory)
  File "bot/exts/backend/branding/_repository.py", line 179, in construct_event
    meta_bytes = await self.fetch_file(contents["meta.md"].download_url)
  File "bot/exts/backend/branding/_repository.py", line 126, in fetch_file
    raise RuntimeError(f"Failed to fetch file due to status: {response.status}")

Could not construct event 'events/snake_day'.

This caused some events to be skipped, and the server's branding reverts to the evergreen branding.

We should make this resilient somehow. Potentially not changing the branding if a retry doesn't work.
@ChrisLovering ChrisLovering transferred this issue from python-discord/site Nov 9, 2023
@kwzrd
Copy link
Contributor

kwzrd commented Nov 10, 2023

I would like to look into this. I can implement some retry mechanism. I could also make the requests concurrent so that the sync is much faster and it'd be nice to add some tests.

@kwzrd kwzrd mentioned this issue Dec 28, 2023
Closed
@kwzrd kwzrd linked a pull request Oct 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwzrd kwzrd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Branding: improve IO resilience kwzrd/pydis-bot
Branding: improve IO resilience kwzrd/pydis-bot
1 participant
@kwzrd