Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of Voice Verified role not logged when using !tvmute #2835

Open
minalike opened this issue Dec 4, 2023 · 4 comments
Open

Removal of Voice Verified role not logged when using !tvmute #2835

minalike opened this issue Dec 4, 2023 · 4 comments
Labels
a: moderation Related to community moderation functionality: (moderation, defcon, verification) s: planning Discussing details type: revision

Comments

@minalike
Copy link
Member

minalike commented Dec 4, 2023

I noticed that when using the bot command !tvmute the removal of the Voice Verified role (if the user currently has it) is not logged to #user-log.

Example and repro in mod channel:
https://ptb.discord.com/channels/267624335836053506/305126844661760000/1181339754667716649
https://ptb.discord.com/channels/267624335836053506/528976905546760203/1181337088562561166

@minalike minalike added the a: moderation Related to community moderation functionality: (moderation, defcon, verification) label Dec 4, 2023
@ChrisLovering
Copy link
Member

This behaviour seems to be on purpose, and caused by this LoC https://github.com/python-discord/bot/blob/main/bot/exts/moderation/infraction/infractions.py#L536

If it's decided that this should now be logged, then that line is the one to remove.

@minalike
Copy link
Member Author

minalike commented Dec 4, 2023

I guess we have history in the code base of intentionally ignoring logs for voice verification-related events (#2076). I'd be in favor of not ignoring.

@ChrisLovering
Copy link
Member

It's used in a few places, can see them all here https://github.com/search?q=repo%3Apython-discord%2Fbot+.ignore%28&type=code

@wookie184
Copy link
Contributor

The main benefit of ignores I can think of is when just searching for a user ID to try and get an overview of their actions - ignoring events which already have matching logs makes the result a bit easier to read through.

That said, if there's a use case where having the events would be useful I'd have no problem with adding them back in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: moderation Related to community moderation functionality: (moderation, defcon, verification) s: planning Discussing details type: revision
Projects
None yet
Development

No branches or pull requests

3 participants