Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/tag command output bugs #2583

Closed
TizzySaurus opened this issue May 7, 2023 · 5 comments
Closed

/tag command output bugs #2583

TizzySaurus opened this issue May 7, 2023 · 5 comments
Labels
a: frontend Related to output and formatting a: tags Related to bot tags good first issue Good for newcomers l: 0 - beginner p: 2 - normal Normal Priority s: planning Discussing details t: bug Something isn't working

Comments

@TizzySaurus
Copy link
Contributor

When executing the command /tag without any arguments, a list of all tags is displayed. However, for some reason there's a random bullet point at the top of the list:
Screenshot 2023-05-07 at 14 04 15

Similarly, when the "Did you mean" message comes up for a non-exact multi-match, such as /tag name:f-str, the "Did you mean ..." has a space before the ... that shouldn't be there:
Screenshot 2023-05-07 at 14 13 53

The relevant lines of code appear to be here and here, although I've not delved too deeply into the code so this could be wrong.

@TizzySaurus TizzySaurus added t: bug Something isn't working good first issue Good for newcomers a: frontend Related to output and formatting s: planning Discussing details p: 2 - normal Normal Priority l: 0 - beginner a: tags Related to bot tags labels May 7, 2023
@wookie184
Copy link
Contributor

It's because of tag groups, #1545, we don't have any tag groups yet, so all tags are under the default group which has no name, hence is just a bullet point. Related: #2423

@SamantaTarun
Copy link

I would like to work on this issue.

@RohanJnr
Copy link
Member

@tarunsamanta2k20 hey, are you stilling working on this ?

@RohanJnr
Copy link
Member

RohanJnr commented May 18, 2023

These are some of changes we should be doing:

  • Change the tag embed footer to remove prefix and use /
    image

  • We need better help message to tell users on how to use tags from a group. Currently, the syntax to view a tag from a group is /tag name:<group_name> <tag_name>, this has to be mentioned in the tag help message.
    image

  • We could also change the slash command auto complete to show tags under groups and invoke them by just selecting it from the suggested items. Currently, only tag names outside groups are shown

@hedyhli
Copy link
Member

hedyhli commented Apr 13, 2024

An update on the points proposed in the issue:

@RohanJnr, regarding improving the docs for /tag -- although we don't actually have any tag groups yet, I agree it could perhaps be made clearer. I've opened a separate issue for it since this is unrelated to the /tag output in this issue. (#3014)

Now it looks like the aliases cluttering already have an issue of its own: #2345. So I'll close this issue since everything mentioned has been addressed.

@hedyhli hedyhli closed this as completed Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: frontend Related to output and formatting a: tags Related to bot tags good first issue Good for newcomers l: 0 - beginner p: 2 - normal Normal Priority s: planning Discussing details t: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants