-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: load TON chain configuration from yaml store #2185
refactor: load TON chain configuration from yaml store #2185
Conversation
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
README.md
Outdated
@@ -108,6 +108,7 @@ after `--`, for instance you could run `pnpm test -- --concurrency 2`. | |||
checks, as well as whatever other code checks any packages support. | |||
- `pnpm fix`: Run auto fixes, including reformatting code and auto-fixing lint | |||
rules where possible. | |||
- `pnpm turbo build`: Build all packages in the monorepo using turborepo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove this line, there shouldn't usually be a good reason to build all packages in the monorepo with turbo -- instead we should be doing things like linting / testing / starting / etc and let turbo build what needs to be built.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @jayantk I'm not sure how we should be updating Devin's PRs....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might understand github comments, not sure. we'll find out though.
I think this might be a setup problem in the repo for contract_manager, because pnpm build:ci
doesn't seem to work there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meta comment is i do think a bit more docs here would be useful. based on these directions, I don't know how to run scripts or anything. Last time i worked with contract manager i spent some time digging around to figure this out.
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
contract_manager/package.json
Outdated
"build": "tsc", | ||
"build": "pnpm run build:cjs && pnpm run build:esm", | ||
"build:cjs": "tsc -p tsconfig.json", | ||
"build:esm": "tsc -p tsconfig.esm.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably get reverted, this needs more testing before we should ship something like it
contract_manager/tsconfig.esm.json
Outdated
"module": "esnext", | ||
"outDir": "./lib/esm" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should revert this
e53a3fb
to
58f900b
Compare
This PR updates the TON contract upgrade script to load chain configuration from yaml files instead of hardcoding RPC URLs.
Changes:
Testing:
Link to Devin run: https://app.devin.ai/sessions/a73a806f601a44538f8e9260208f22cf