feat(staking): implement some feedback items #1918
Conversation
cprussin
commented
Sep 13, 2024
cprussin
commented
- Fix alignment of stake account indicator in header
- Update language of opt-out modal
- Round APY in publishers table to 2 digits
- Show estimated APY even if amount exceeds wallet balance
- Separate main account from other accounts in stake account menu
- Store last selected stake account in local storage
- Fix alignment of stake account indicator in header - Update language of opt-out modal - Round APY in publishers table to 2 digits - Show estimated APY even if amount exceeds wallet balance - Separate main account from other accounts in stake account menu - Store last selected stake account in local storage
|
@cprussin is attempting to deploy a commit to the pyth-web Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
| import { useLogger } from "../../hooks/use-logger"; | ||
| import { usePrimaryDomain } from "../../hooks/use-primary-domain"; | ||
| import { AccountHistory } from "../AccountHistory"; | ||
| import { Button } from "../Button"; | ||
| import { ModalDialog } from "../ModalDialog"; | ||
| import { TruncatedKey } from "../TruncatedKey"; | ||
|
|
||
| const ONE_SECOND_IN_MS = 1000; | ||
| const ONE_MINUTE_IN_MS = 60 * ONE_SECOND_IN_MS; | ||
| const REFRESH_INTERVAL = 1 * ONE_MINUTE_IN_MS; |
There was a problem hiding this comment.
@keyvankhademi it's a bit clunky because this is duplicated in two places since the dashboard data needs to be loaded now in the wallet menu too so we can display which account is the main account. So we have to do the useData call on the dashboard data. But it won't trigger a separate network call because swr will re-use the global cache, and this will go away when I refactor the dashboard data into use-api eventually, so I don't think it's a big issue to leave the duplication for now.
There was a problem hiding this comment.
oh ignore my last comment then, i just saw this.
| @@ -16,6 +16,10 @@ import { Error as ErrorPage } from "../Error"; | |||
| import { Loading } from "../Loading"; | |||
| import { NoWalletHome } from "../NoWalletHome"; | |||
|
|
|||
| const ONE_SECOND_IN_MS = 1000; | |||
There was a problem hiding this comment.
we can have these in a global constants file to avoid repetition.
There was a problem hiding this comment.
Yeah, I'll refactor them in eventually, but it will go away when I clean up use-api anyways
