feat(staking): add reassign/opt out publisher rewards #1916
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
| client: PythStakingClient, | ||
| stakeAccount: PublicKey, | ||
| targetAccount: PublicKey, | ||
| publisherKey: PublicKey, |
There was a problem hiding this comment.
I feel like this should be derived in the SDK -- it's not valid to call setPublisherStakeAccount if the stakeAccount isn't the one assigned to the publisherKey so the stake account should be all we need right? Or in other words the stake account implies a specific publisher key, so it doesn't really make sense to pass both.
There was a problem hiding this comment.
The reason I did that was to avoid fetching this data. I can fetch this data from the sdk by making an rpc call but I wanted to avoid increasing the number of rpc call. Do you still think it's better to do it this way?
There was a problem hiding this comment.
hm, I'm not sure if I really have a strong opinion, let's leave it as is and revisit later.
No description provided.