Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the public interface? (let me know what you actually use) #54

Open
altendky opened this issue Jan 15, 2019 · 4 comments
Open

What is the public interface? (let me know what you actually use) #54

altendky opened this issue Jan 15, 2019 · 4 comments

Comments

@altendky
Copy link
Member

altendky commented Jan 15, 2019

With everything in one file, being a module distribution (rather than package), and having only the readme as documentation I'm left a little unclear about what is 'public interface' and what isn't. I'd like to make this more explicit so that going forward we don't have to think about this on a case by case basis every time we feel like tweaking something. (also, maybe I want a package with versioneer and explicit public interface and tests inside like I'm used to...)

The readme references:

  • pytest options
    • -p no:twisted
    • --reactor
  • pytest fixtures
    • twisted_greenlet
  • import pytest
    • Not in the readme anymore but they were as of v1.6 (2018.01.11) and have no deprecation notices
    • @inlineCallbacks
    • blockon()
  • import pytest_twisted
    • init_default_reactor()
    • init_qt5_reactor()
    • @pytest_twisted.inlineCallbacks
    • blockon()

The remaining items are:

  • 'public'
    • blockon_default()
    • block_from_thread()
    • init_twisted_greenlet()
    • stop_twisted_greenlet()
    • reactor_installers
  • 'private'
    • _config
    • _instances
    • _install_reactor()
  • pytest_*
    • pytest_pyfunc_call()
    • pytest_addoption()
    • pytest_configure()
    • _pytest_pyfunc_call()
@meejah
Copy link

meejah commented Jan 15, 2019

I use pytest.inlineCallbacks and pytest.blockon

@altendky
Copy link
Member Author

@ThreePinkApples
Copy link

I use

from pytest_twisted import inlineCallbacks

@ktdreyer
Copy link

I use @pytest_twisted.inlineCallbacks and pytest_twisted.blockon(deferred)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants