Skip to content

Latest commit

 

History

History
33 lines (21 loc) · 1.17 KB

CONTRIBUTING.rst

File metadata and controls

33 lines (21 loc) · 1.17 KB

What it takes to add a new reactor:

  • In pytest_twisted.py
    • Write an init_foo_reactor() function
    • Add 'foo': init_foo_reactor, to reactor_installers where the key will be the string to be passed such as --reactor=foo.
  • In testing/test_basic.py
    • Add test_blockon_in_hook_with_foo() with skip_if_reactor_not('foo') as the first line
    • Add test_wrong_reactor_with_foo() with skip_if_reactor_not('foo') as the first line
  • In tox.ini
    • Adjust envlist to include the fooreactor factor for the appropriate versions of Python
    • Add conditional deps for the new reactor such as foo: foobar to the appropriate test environments
    • Add fooreactor: pytest --reactor=foo to the commands list
  • In .travis.yml
    • Consider any extra system packages which may be required
  • In appveyor.yml
    • Add the new reactor environment to the TOXENV for each relevant Python
Reference reactor additions: