Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytest_runtest_logreport not called on reruns #108

Open
christiansandberg opened this issue Apr 25, 2020 · 2 comments · May be fixed by #124
Open

pytest_runtest_logreport not called on reruns #108

christiansandberg opened this issue Apr 25, 2020 · 2 comments · May be fixed by #124
Assignees
@gnikonorov
Milestone
10.0 Release

Comments

@christiansandberg
Copy link

It seems the pytest_runtest_logreport hook is not called for each phase if a previous phase failed. The break statement in the pytest_runtest_protocol implementation stops processing the rest of the reports.
@icemac
Copy link
Contributor

icemac commented May 8, 2020

What would you suggest to do instead?

@gnikonorov gnikonorov self-assigned this Aug 2, 2020
@gnikonorov gnikonorov linked a pull request Aug 2, 2020 that will close this issue
Open
@sallner sallner added this to the 9.1 Release milestone Aug 3, 2020
@sallner sallner modified the milestones: 9.1 Release, 9.2 Release Aug 26, 2020
@BeyondEvil
Copy link
Contributor

I just noticed this issue.

Not sure if it is an issue, but it is at least unexpected behaviour.

I maintain pytest-html and whilst a "teardown" is executed - it's not reported by the pytest_runtest_logreport . This in turn means that the generated report is missing information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnikonorov gnikonorov

Labels
None yet
Projects
None yet
Milestone
10.0 Release
5 participants
@icemac @christiansandberg @gnikonorov @BeyondEvil @sallner