Set faker_seed fixture to session scope #657
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faker has changed its main fixture to be session scoped in v32 and uses faker_seed, so this needs to match. Fix pytest-dev#656
browniebroke
commented
Nov 14, 2024
| @@ -663,7 +663,7 @@ def test_one(faker): | |||
| assert faker.name() == 'Ryan Gallagher' | |||
|
|
|||
| def test_two(faker): | |||
| assert faker.name() == 'Ryan Gallagher' | |||
| assert faker.name() == 'Jon Cole' | |||
There was a problem hiding this comment.
This line changed when I updated faker to v32 🤔
|
I've reverted Faker's change in |
Ok so I suppose we don't actually need this change anymore then, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faker has changed its main fixture to be session scoped in v32 and uses
faker_seed:So the fixture from
pytest-randomlyneeds to match the same scopeFix #656