Are /usr/bin/env python lines needed?

[rominf]

pytest-localserver/pytest_localserver/plugin.py

Line 1 in bebb98b

#!/usr/bin/env python

is useless since there is nothing except fixtures in the file.

I'm not sure about this:

pytest-localserver/pytest_localserver/smtp.py

Line 1 in bebb98b

#!/usr/bin/env python

since there is a code:

pytest-localserver/pytest_localserver/smtp.py

Lines 101 to 122 in bebb98b

	if __name__ == "__main__": # pragma: no cover
	import time
	server = Server()
	server.start()
	print('SMTP server is running on %s:%i' % server.addr)
	print('Type <Ctrl-C> to stop')
	try:
	try:
	while True:
	time.sleep(1)
	finally:
	print('\rstopping...')
	server.stop()
	except KeyboardInterrupt:
	# support for Python 2.4 dictates that try ... finally is not used
	# together with any except statements
	pass

but it's ancient; not sure if someone still uses it.

[diazona]

Agreed, it would also be my preference to remove that code. I don't think these files need to be runnable from the command line; or if we do want to allow that, it makes sense to put it in a console script. But I don't want to make a mess of @redtoad's fine work either 😄 and I don't know if maybe there is some reason to keep that code around that I'm not seeing.

Anyway, if neither of my co-maintainers suggests otherwise, I'd be happy to accept a pull request that removes these parts of the code, if you feel like preparing one. Otherwise, I'll get around to it at some point (though likely not for the 0.6 release).

[redtoad]

Hmm... What was I thinking back then.

The shebang directive in plugin.py is useless, I agree.

The one in smtp.pyis not strictly necessary since this can be started using python -m pytest_localserver.smtp. The main block I added for testing, if I remember correctly, and would not remove.

[RonnyPfannschmidt]

i would recommend to move the main block to a main function and just calling it in the dunder main block

[diazona]

Could we put the testing code in a separate module? I kind of figured that's what we have test files for, e.g. tests/test_smtp.py or another test file.

[diazona]

I just realized what you meant by "testing" in this case, i.e. not automated testing 🤦 so yeah, it makes sense to keep the code but I would also put it in a function. I'll do that in a PR soon.

[diazona]

#67