Incompatibility with flask-babel

[azmeuk]

I found an incompatibility when using at the same time flask-babel 4.0.0 and pytest-flask 1.3.0.
I am not sure whose responsability it is, maybe both, maybe neither, so I post this issue on both bugtrackers.
Here is the link to the issue at flask-babel.

In the following snippet, a dummy view translates a dummy string and returns the current lang code.
The lang code is dynamically set by a request argument lang.
In this test environment the first visit is successful and sets the lang to fr but the second visit fails and the lang is not set to uk but still is fr.

import pytest
from flask import Flask
from flask import render_template_string
from flask import request
from flask import g
from flask_babel import Babel


def locale_selector():
    if request.args.get("lang"):
        g.lang = request.args["lang"]

    return g.get("lang", "en")


@pytest.fixture
def app():
    app = Flask(__name__)
    Babel(app, locale_selector=locale_selector)

    @app.route("/")
    def index():
        render_template_string("{% trans %}foobar{% endtrans %}")
        return g.get("lang")

    return app


def test_foobar(app):
    client_app = app.test_client()

    res = client_app.get("/?lang=fr")
    assert res.text == "fr"

    res = client_app.get("/?lang=en")
    assert res.text == "en" # This assertion fails

Note that this test fails if pytest-flask is installed in the environment, but passes if pytest-flask is not installed. In production, the behavior is OK too, so there is going on with pytest-flask.

With a little debugging, I can see that the locale_selector method is only called once.
That explains why the language stays to fr.
Looking closer, it seems that the get_locale method from flask-babel saves the loaded lang in the current context and reuses it on following calls.
On different requests the language would indeed be recomputed.

https://github.com/python-babel/flask-babel/blob/a754eade39d9850693dd2b645ae8a2545df7fdf7/flask_babel/__init__.py#L257-L258

However, as far as I understand, pytest-flask loads a context for the unit tests (so session and g are accessible without loading a new context). That probably makes flask-babel not recomputing the locale, because the same context is used, and leads to my test failing.

Please correct me if my analysis is wrong. I don't know if there is a mis-usage from my side or if the two libraries do not belong together. If they don't, I hope we can find a solution by bringing every one in the same room :)

What do you think?

[azmeuk]

Thanks to @tkteck insight I could narrow down the test to this:

import pytest
from flask import Flask
from flask import request
from flask import g


@pytest.fixture
def app():
    app = Flask(__name__)

    @app.route("/")
    def index():
        if "lang" not in g:
            g.lang = request.args["lang"]
        return g.get("lang")

    return app


def test_foobar(app):
    client_app = app.test_client()

    res = client_app.get("/?lang=fr")
    assert res.text == "fr"

    res = client_app.get("/?lang=en")
    assert res.text == "en" # This assertion fails

So it seems that g is kept between requests. I could not find any documentation about this behavior. Is this a bug in pytest-flask?

[RonnyPfannschmidt]

a test request context is automatically pushed, this might throw flask-babel off

however i believe that test client requests ought to happen in a pushed context, so its not clear to me whats going on there

[RonnyPfannschmidt]

based on https://flask.palletsprojects.com/en/2.3.x/testing/#accessing-and-modifying-the-session i under the impression that the pytest-flask default behaviour is wrong

[azmeuk]

The code responsible for pushing a new context is this one:

pytest-flask/src/pytest_flask/plugin.py

Lines 106 to 133 in f04d3c2

	@pytest.fixture(autouse=True)
	def _push_request_context(request):
	"""During tests execution request context has been pushed, e.g. `url_for`,
	`session`, etc. can be used in tests as is::
	def test_app(app, client):
	assert client.get(url_for('myview')).status_code == 200
	"""
	if "app" not in request.fixturenames:
	return
	app = getfixturevalue(request, "app")
	# Get application bound to the live server if ``live_server`` fixture
	# is applied. Live server application has an explicit ``SERVER_NAME``,
	# so ``url_for`` function generates a complete URL for endpoint which
	# includes application port as well.
	if "live_server" in request.fixturenames:
	app = getfixturevalue(request, "live_server").app
	ctx = app.test_request_context()
	ctx.push()
	def teardown():
	ctx.pop()
	request.addfinalizer(teardown)

This seems to be on purpose so url_for, g, session etc. are directly available on the test files.

[RonnyPfannschmidt]

Yes,and based on modern flasks tests utilities,one should use the context Managers for correct control over globals

[azmeuk]

If flask changed the rules, I wonder if there is a solution that would keep the same behavior in pytest-flask.

Maybe providing g, session and url_for fixtures would fix my situation and be less intrusive? If that solution was considered, I might work on a PR.

[RonnyPfannschmidt]

Im currently not deeply working with flask, so I am unable to provide a correct assessment of the details

I just inferred from the examples in flask that the tools in pytest-flask are overstepping

I'll send this question towards the flask maintainers