Project name based collection triggers regression #99
Assignees
Comments
goodboy
pushed a commit
to goodboy/pluggy
that referenced
this issue
Nov 13, 2017
Triggers a regression introduced during refactoring of the multicall loop. Demonstrates the issue described in pytest-dev#99.
|
To fix this we can bring in the spec-as-object wrapping stuff from #57 which should resolve this. |
goodboy
pushed a commit
to goodboy/pluggy
that referenced
this issue
Nov 13, 2017
Triggers a regression introduced during refactoring of the multicall loop. Demonstrates the issue described in pytest-dev#99.
goodboy
pushed a commit
to goodboy/pluggy
that referenced
this issue
Nov 18, 2017
Multi-call loop(s) should not care about spec opts - only whether or not the first result should be returned. Fix issue where a collected but unmarked hook not having `_HookCaller.spec_opts` defined results in an attr error. Resolves pytest-dev#99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'll put up a test which demonstrates this shortly.
We also don't seem to have any tests which don't also include adding a
hookspecthe lack of which is the source of the problem.The text was updated successfully, but these errors were encountered: