You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@WebReflection responding here to the ping you sent me on Discord for visibility - it seems there have been updates to mip as you can see here. The most relevant change, i think, is quite a bit of additional detail and work around _download_file(), which has some additional error handling... but our (older) version also writes files in binary (wb) mode, so I'm not positive that's the culprit.
In any case, it would probably be good to update our version of Mip to reflect some of those new changes.
Hi @JeffersGlass I did talk to @dpgeorge and there's more to it ... we're using synchronous XHR which can't provide arrayBuffer as response due browsers limitations around its synchronous nature (when specified) but once we make the XHR async we're better off with fetch instead, as that's not deprecated.
In pyodide the dance to install packages is already async so I think a whole rewrite would be for good but Damien mentioned that maybe the mip.py logic should be provided by MicroPython itself, which is closer to upstream changes around mip in general, and we can just pre-parse / amend our own github: prefix dance when any package uses that convention ... thoughts?
Context here: pyscript/pyscript#2063
The text was updated successfully, but these errors were encountered: