Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: pysat 3.2.0 compatibility #51

Open
jklenzing opened this issue Dec 1, 2023 · 2 comments · May be fixed by #59
Open

MAINT: pysat 3.2.0 compatibility #51

jklenzing opened this issue Dec 1, 2023 · 2 comments · May be fixed by #59
Assignees

Comments

@jklenzing
Copy link
Member

pysat 3.2.0 changes how parse_fixed_width_filenames works. For an empty fileset, values are returned as None rather than an empty list. This is a breaking change for the cosmic_gps instrument.

Since len cannot be run on NoneType, the check for files is updated to

stored['year'] is not None and len(stored['year']) > 0

where the first bit is the pysat 3.2.0 version, and the second bit is the pysat 3.1.0 check. When 3.2.0 is released, this can be simplified and a version limit can be added.

@jklenzing
Copy link
Member Author

There is an additional issue with pysat 3.2.0 tests failing on github actions. The tests are killed prematurely.

Cannot test this locally, as tests are killed for any pysat version prematurely.

@jklenzing
Copy link
Member Author

Fixed in pysat with pysat/pysat#1199. Cap can be removed with release of pysat 3.2.1

@jklenzing jklenzing self-assigned this Jul 30, 2024
@jklenzing jklenzing linked a pull request Oct 7, 2024 that will close this issue
11 tasks
@jklenzing jklenzing linked a pull request Oct 7, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant