We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geom_col
element_as_gdf()
#720 introduced a small ruff regression where the geom_col keyword is no longer used in util._arcs_as_gdf(), which triggers a ruff failure in pre-commit.
ruff
util._arcs_as_gdf()
The thought here is that maybe we should remove the geom_col argument in element_as_gdf()? And always default to "geometry".
"geometry"
EDIT
v1.8.0
The text was updated successfully, but these errors were encountered:
Can you think of a use case when you want the column to be called differently and it couldn't be done via an intermediate rename_geometry call?
rename_geometry
Sorry, something went wrong.
Nope, I can't think of anything. Let's nix it.
jGaboardi
martinfleis
No branches or pull requests
#720 introduced a small
ruff
regression where thegeom_col
keyword is no longer used inutil._arcs_as_gdf()
, which triggers aruff
failure in pre-commit.The thought here is that maybe we should remove the
geom_col
argument inelement_as_gdf()
? And always default to"geometry"
.EDIT
v1.8.0
The text was updated successfully, but these errors were encountered: