Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test that notebook run #82

Open
knaaptime opened this issue Jan 3, 2020 · 1 comment
Open

test that notebook run #82

knaaptime opened this issue Jan 3, 2020 · 1 comment

Comments

@knaaptime
Copy link
Member

the current CI setup tests that the book builds, but does not test that it actually runs, which can be super confusing to users if our canonical tutorials have trouble running. Once #81 is addressed, it would be trivial to make sure that notebooks run using nconvert in thew travis config

@darribas
Copy link
Member

darribas commented Jan 6, 2020

+1!!! Checking, it might actually be very straightforward, as the CL tool already allows for execution of notebooks:

notebooks/lib/build.py

Lines 246 to 247 in c86bd66

if args.test_run:
_ = test_notebooks(execute=True)

So should be a switch on the CI only. Not sure if they'll be too heavy to run every single time, but at the very least we should enforce the practice of making sure the pass locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants