Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined local variable used in search.py: golden_section (Line 46, 47) #147

Open
xyluo25 opened this issue Feb 13, 2024 · 2 comments
Open

Comments

@xyluo25
Copy link

xyluo25 commented Feb 13, 2024

Hi Developers,

please check the error exist in search.py in line 46 and 47.
image

Do we need to add n as a parameter in function golden_section or we will remove n in the function?

@jGaboardi
Copy link
Member

@xyluo25 Instead of posting screenshots of code, you can include the permalink to the exact location by clicking next to the line number for a pop-up dialogue box like so:

Screenshot 2024-02-13 at 7 41 20 PM

Then you can easily embed the permalink here with markdown syntax like: [some text](url). For example: "The relevant lines in the golden_section() function are here". Or you can simply paste the permalink in here and get a nice rendering of the code with a functional hyperlink:

mgwr/mgwr/search.py

Lines 46 to 47 in 423726a

b = a + delta * np.abs(n - a)
d = n - delta * np.abs(n - a)

@xyluo25
Copy link
Author

xyluo25 commented Feb 14, 2024

Hello @jGaboardi, thank you for sharing this information. I've learned so much from you. I plan to implement it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants