-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shape_index is the same as radii_ratio #248
Comments
I like the “radii_ratio” name, since it expresses its structure as the ratio of two ideal shape radii. The two implementations are basically the same, though I find the one with more lines to be easier to understand. We can always alias one as the other? |
Yeah, I also like the radii ratio better as shape index is too generic. All of them are shape indices. Agree that the multiline version is a bit more readable.
Yeah but I don't think there's a ton of downstream usage of this so I would simply deprecate |
I will never pass up an opportunity to deprecate! |
We have a duplication in shape indices.
shape_index
is the same asradii_ratio
.esda/esda/shape.py
Line 356 in 17c5f00
and
esda/esda/shape.py
Lines 193 to 195 in 17c5f00
are the same formulas.
We should probably deprecate one in favour of the other.
The text was updated successfully, but these errors were encountered: