Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derivative term in the PID #507

Open
Bentwin2002 opened this issue Jan 29, 2024 · 3 comments
Open

Derivative term in the PID #507

Bentwin2002 opened this issue Jan 29, 2024 · 3 comments

Comments

@Bentwin2002
Copy link

Do you know why the D term in the PID was deactivated? Has anyone had any success reactivating and using the D term?

@michaelcroquette
Copy link
Collaborator

The D term was unused in our experiments most of the time so we removed it. It is active in the default RedPitaya PID module if you really need it.

@mixgreen
Copy link

The D term was unused in our experiments most of the time so we removed it. It is active in the default RedPitaya PID module if you really need it.

Is that mean i can't use the D term in pyrpl? if i really need it , is that posiable to uncomment the code to use it?
image
image
image

@michaelcroquette
Copy link
Collaborator

Actually you can ! I thought the derivative had been disabled in fpga code but it was actually uncommented in #22. There is a comment in the code saying "Derivative - 2 cycles delay (but treat as 1 cycle because its not functional at the moment" but I'm not sure what it means.
The python code of the PID module was commented in #299 but there is no mention of this modification in the commit description.
Anyway you can try and see ! It looks like the fpga code is the same as the original one from redpitaya so I think it should work. If it works we will uncomment it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants