Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The library ignores main application QSettings usage #14

Open
me21 opened this issue Sep 12, 2013 · 0 comments
Open

The library ignores main application QSettings usage #14

me21 opened this issue Sep 12, 2013 · 0 comments

Comments

@me21
Copy link

me21 commented Sep 12, 2013

The library uses its own variable for settings storage, at least in fvignoredversions.cpp (autoupdate branch). When an application uses the library, it might end up storing settings in two different places: one for application settings (if it stores them, for example, in IniFormat), one for Fervor.
I believe this is harder to understand, to maintain and to configure after deploy, than in case where application provides Fervor library with settings variable. The application author would then be free to decide how he wants to store settings, he wouldn't have to comply with library requirements.
I propose to roll back the commit c76d4bc ("reinstate access to QSettings to store ignored version").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant