Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.whl.metadata file downloads are recorded with filetype=bdist_wheel #16207

Open
alex opened this issue Jul 1, 2024 · 1 comment
Open

.whl.metadata file downloads are recorded with filetype=bdist_wheel #16207

alex opened this issue Jul 1, 2024 · 1 comment

Comments

@alex
Copy link
Member

alex commented Jul 1, 2024

These should probably have a distinct filetype, they're not actually wheels.

@di di transferred this issue from pypi/linehaul-cloud-function Jul 2, 2024
@di
Copy link
Member

di commented Jul 2, 2024

Transferring this to https://github.com/pypi/warehouse/ as the primary issue is with how we store the file.

This value is passed from the object storage metadata (via the x-amz-meta-package-type header) to the download logs.

It's set here:

storage.store(
file_.metadata_path,
os.path.join(tmpdir, filename + ".metadata"),
meta={
"project": file_.release.project.normalized_name,
"version": file_.release.version,
"package-type": file_.packagetype,
"python-version": file_.python_version,
},
)

We probably need to figure out a new "package type" to change this to. We'll need to update linehaul to be able to parse this new package type as well.

@miketheman miketheman changed the title .whl.metdata file downloads are recorded with filetype=bdist_wheel .whl.metadata file downloads are recorded with filetype=bdist_wheel Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants