-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipenv lock
does not list all hashes in Pipfile.lock when using private/custom index
#6249
Comments
@FlavioAmurrioCS Could you check on if #6252 fixes the issue for your example case? EDIT: Actually I am having problems with that branch, let me update you when I get further. EDITx2: Ok, I reviewed some things, if you could try my branch and report on if it helps with the issue you report would be helpful at this point. |
I have tested #6252 and it does not fix the issue. |
@FlavioAmurrioCS I rebased the PR above and would appreciate if you could re-check the behavior. Removing cached property from python finder is not ideal, but I see it was added to the |
@matteius Latest changes do not work. I am seeing it not even including the hashes at all for private repo, public still works fine thou. {
"_meta": {
"hash": {
"sha256": "c3b872081b72f55e24e12ad0a6dce4ed2bfc539ab86cca633805c49c2a8adcaf"
},
"pipfile-spec": 6,
"requires": {
"python_version": "3.10"
},
"sources": [
{
"name": "pypi",
"url": "http://localhost:8080/simple/",
"verify_ssl": false
}
]
},
"default": {
"frozenlist": {
"index": "pypi",
"version": "==1.4.1"
}
},
"develop": {}
}
|
@FlavioAmurrioCS can you try this branch? #6282 |
@matteius #6282 seems to be working! Let me try it with artifactory. {
"_meta": {
"hash": {
"sha256": "bf2ead9c5a928b30a3d629d3e0cc141c5e2e4a9928213b69c7cddc0bc99f83f0"
},
"pipfile-spec": 6,
"requires": {
"python_version": "3.12"
},
"sources": [
{
"name": "pypi",
"url": "http://localhost:8080/simple/",
"verify_ssl": false
}
]
},
"default": {
"frozenlist": {
"hashes": [
"sha256:04ced3e6a46b4cfffe20f9ae482818e34eba9b5fb0ce4056e4cc9b6e212d09b7",
"sha256:0633c8d5337cb5c77acbccc6357ac49a1770b8c487e5b3505c57b949b4b82e98",
"sha256:068b63f23b17df8569b7fdca5517edef76171cf3897eb68beb01341131fbd2ad",
"sha256:0c250a29735d4f15321007fb02865f0e6b6a41a6b88f1f523ca1596ab5f50bd5",
"sha256:1979bc0aeb89b33b588c51c54ab0161791149f2461ea7c7c946d95d5f93b56ae",
"sha256:1a4471094e146b6790f61b98616ab8e44f72661879cc63fa1049d13ef711e71e",
"sha256:1b280e6507ea8a4fa0c0a7150b4e526a8d113989e28eaaef946cc77ffd7efc0a",
"sha256:1d0ce09d36d53bbbe566fe296965b23b961764c0bcf3ce2fa45f463745c04701",
"sha256:20b51fa3f588ff2fe658663db52a41a4f7aa6c04f6201449c6c7c476bd255c0d",
"sha256:23b2d7679b73fe0e5a4560b672a39f98dfc6f60df63823b0a9970525325b95f6",
"sha256:23b701e65c7b36e4bf15546a89279bd4d8675faabc287d06bbcfac7d3c33e1e6",
"sha256:2471c201b70d58a0f0c1f91261542a03d9a5e088ed3dc6c160d614c01649c106",
"sha256:27657df69e8801be6c3638054e202a135c7f299267f1a55ed3a598934f6c0d75",
"sha256:29acab3f66f0f24674b7dc4736477bcd4bc3ad4b896f5f45379a67bce8b96868",
"sha256:32453c1de775c889eb4e22f1197fe3bdfe457d16476ea407472b9442e6295f7a",
"sha256:3a670dc61eb0d0eb7080890c13de3066790f9049b47b0de04007090807c776b0",
"sha256:3e0153a805a98f5ada7e09826255ba99fb4f7524bb81bf6b47fb702666484ae1",
"sha256:410478a0c562d1a5bcc2f7ea448359fcb050ed48b3c6f6f4f18c313a9bdb1826",
"sha256:442acde1e068288a4ba7acfe05f5f343e19fac87bfc96d89eb886b0363e977ec",
"sha256:48f6a4533887e189dae092f1cf981f2e3885175f7a0f33c91fb5b7b682b6bab6",
"sha256:4f57dab5fe3407b6c0c1cc907ac98e8a189f9e418f3b6e54d65a718aaafe3950",
"sha256:4f9c515e7914626b2a2e1e311794b4c35720a0be87af52b79ff8e1429fc25f19",
"sha256:55fdc093b5a3cb41d420884cdaf37a1e74c3c37a31f46e66286d9145d2063bd0",
"sha256:5667ed53d68d91920defdf4035d1cdaa3c3121dc0b113255124bcfada1cfa1b8",
"sha256:590344787a90ae57d62511dd7c736ed56b428f04cd8c161fcc5e7232c130c69a",
"sha256:5a7d70357e7cee13f470c7883a063aae5fe209a493c57d86eb7f5a6f910fae09",
"sha256:5c3894db91f5a489fc8fa6a9991820f368f0b3cbdb9cd8849547ccfab3392d86",
"sha256:5c849d495bf5154cd8da18a9eb15db127d4dba2968d88831aff6f0331ea9bd4c",
"sha256:64536573d0a2cb6e625cf309984e2d873979709f2cf22839bf2d61790b448ad5",
"sha256:693945278a31f2086d9bf3df0fe8254bbeaef1fe71e1351c3bd730aa7d31c41b",
"sha256:6db4667b187a6742b33afbbaf05a7bc551ffcf1ced0000a571aedbb4aa42fc7b",
"sha256:6eb73fa5426ea69ee0e012fb59cdc76a15b1283d6e32e4f8dc4482ec67d1194d",
"sha256:722e1124aec435320ae01ee3ac7bec11a5d47f25d0ed6328f2273d287bc3abb0",
"sha256:7268252af60904bf52c26173cbadc3a071cece75f873705419c8681f24d3edea",
"sha256:74fb4bee6880b529a0c6560885fce4dc95936920f9f20f53d99a213f7bf66776",
"sha256:780d3a35680ced9ce682fbcf4cb9c2bad3136eeff760ab33707b71db84664e3a",
"sha256:82e8211d69a4f4bc360ea22cd6555f8e61a1bd211d1d5d39d3d228b48c83a897",
"sha256:89aa2c2eeb20957be2d950b85974b30a01a762f3308cd02bb15e1ad632e22dc7",
"sha256:8aefbba5f69d42246543407ed2461db31006b0f76c4e32dfd6f42215a2c41d09",
"sha256:96ec70beabbd3b10e8bfe52616a13561e58fe84c0101dd031dc78f250d5128b9",
"sha256:9750cc7fe1ae3b1611bb8cfc3f9ec11d532244235d75901fb6b8e42ce9229dfe",
"sha256:9acbb16f06fe7f52f441bb6f413ebae6c37baa6ef9edd49cdd567216da8600cd",
"sha256:9d3e0c25a2350080e9319724dede4f31f43a6c9779be48021a7f4ebde8b2d742",
"sha256:a06339f38e9ed3a64e4c4e43aec7f59084033647f908e4259d279a52d3757d09",
"sha256:a0cb6f11204443f27a1628b0e460f37fb30f624be6051d490fa7d7e26d4af3d0",
"sha256:a7496bfe1da7fb1a4e1cc23bb67c58fab69311cc7d32b5a99c2007b4b2a0e932",
"sha256:a828c57f00f729620a442881cc60e57cfcec6842ba38e1b19fd3e47ac0ff8dc1",
"sha256:a9b2de4cf0cdd5bd2dee4c4f63a653c61d2408055ab77b151c1957f221cabf2a",
"sha256:b46c8ae3a8f1f41a0d2ef350c0b6e65822d80772fe46b653ab6b6274f61d4a49",
"sha256:b7e3ed87d4138356775346e6845cccbe66cd9e207f3cd11d2f0b9fd13681359d",
"sha256:b7f2f9f912dca3934c1baec2e4585a674ef16fe00218d833856408c48d5beee7",
"sha256:ba60bb19387e13597fb059f32cd4d59445d7b18b69a745b8f8e5db0346f33480",
"sha256:beee944ae828747fd7cb216a70f120767fc9f4f00bacae8543c14a6831673f89",
"sha256:bfa4a17e17ce9abf47a74ae02f32d014c5e9404b6d9ac7f729e01562bbee601e",
"sha256:c037a86e8513059a2613aaba4d817bb90b9d9b6b69aace3ce9c877e8c8ed402b",
"sha256:c302220494f5c1ebeb0912ea782bcd5e2f8308037b3c7553fad0e48ebad6ad82",
"sha256:c6321c9efe29975232da3bd0af0ad216800a47e93d763ce64f291917a381b8eb",
"sha256:c757a9dd70d72b076d6f68efdbb9bc943665ae954dad2801b874c8c69e185068",
"sha256:c99169d4ff810155ca50b4da3b075cbde79752443117d89429595c2e8e37fed8",
"sha256:c9c92be9fd329ac801cc420e08452b70e7aeab94ea4233a4804f0915c14eba9b",
"sha256:cc7b01b3754ea68a62bd77ce6020afaffb44a590c2289089289363472d13aedb",
"sha256:db9e724bebd621d9beca794f2a4ff1d26eed5965b004a97f1f1685a173b869c2",
"sha256:dca69045298ce5c11fd539682cff879cc1e664c245d1c64da929813e54241d11",
"sha256:dd9b1baec094d91bf36ec729445f7769d0d0cf6b64d04d86e45baf89e2b9059b",
"sha256:e02a0e11cf6597299b9f3bbd3f93d79217cb90cfd1411aec33848b13f5c656cc",
"sha256:e6a20a581f9ce92d389a8c7d7c3dd47c81fd5d6e655c8dddf341e14aa48659d0",
"sha256:e7004be74cbb7d9f34553a5ce5fb08be14fb33bc86f332fb71cbe5216362a497",
"sha256:e774d53b1a477a67838a904131c4b0eef6b3d8a651f8b138b04f748fccfefe17",
"sha256:edb678da49d9f72c9f6c609fbe41a5dfb9a9282f9e6a2253d5a91e0fc382d7c0",
"sha256:f146e0911cb2f1da549fc58fc7bcd2b836a44b79ef871980d605ec392ff6b0d2",
"sha256:f56e2333dda1fe0f909e7cc59f021eba0d2307bc6f012a1ccf2beca6ba362439",
"sha256:f9a3ea26252bd92f570600098783d1371354d89d5f6b7dfd87359d669f2109b5",
"sha256:f9aa1878d1083b276b0196f2dfbe00c9b7e752475ed3b682025ff20c1c1f51ac",
"sha256:fb3c2db03683b5767dedb5769b8a40ebb47d6f7f45b1b3e3b4b51ec8ad9d9825",
"sha256:fbeb989b5cc29e8daf7f976b421c220f1b8c731cbf22b9130d8815418ea45887",
"sha256:fde5bd59ab5357e3853313127f4d3565fc7dad314a74d7b5d43c22c6a5ed2ced",
"sha256:fe1a06da377e3a1062ae5fe0926e12b84eceb8a50b350ddca72dc85015873f74"
],
"index": "pypi",
"markers": "python_version >= '3.8'",
"version": "==1.4.1"
}
},
"develop": {}
} |
Tried it artifactory as well and its working! |
@FlavioAmurrioCS |
Issue description
pipenv lock
does not list all hashes for a dependency version when we use internal pypi mirror (Artifactory).I did some debugging that ultimately led to to find that if we remove @cached_property from
pipenv/pipenv/utils/resolver.py
Lines 329 to 336 in 472b118
Expected result
Pipfile.lock should list all hashes (os/arch) for a specific dependency.
Actual result
Pipfile.lock only list dependencies hash of those that match current os/architecture
Steps to replicate
pipenv lock
$ pipenv --support
Pipenv version:
'2024.0.2'
Pipenv location:
'/Users/flavio/dev/github.com/FlavioAmurrioCS/pipenv/pipenv'
Python location:
'/Users/flavio/.virtualenvs/pipenv-KZWbNTkA/bin/python'
OS Name:
'posix'
User pip version:
'24.0'
user Python installations found:
PEP 508 Information:
System environment variables:
SHELL
USER_ZDOTDIR
ITERM_PROFILE
TWILIO_ACCOUNT_SID
COLORTERM
XPC_FLAGS
HOMEBREW_HOME
HISTCONTROL
TERM_PROGRAM_VERSION
PIPENV_ACTIVE
HISTSIZE
TERM_FEATURES
__CFBundleIdentifier
THEME_THEME
SSH_AUTH_SOCK
MallocNanoZone
TWINE_PASSWORD
TERM_SESSION_ID
HOMEBREW_PREFIX
PIPX_BIN_DIR
PWD
LOGNAME
LaunchInstanceID
VSCODE_GIT_ASKPASS_NODE
TOOL_INSTALLER_PACKAGE_DIR
HATCH_ENV_TYPE_VIRTUAL_PATH
GITHUB_FOLLOW
VSCODE_INJECTION
COMMAND_MODE
APPLICATION_DIR
ITERM_SESSION_ID
PIP_PYTHON_PATH
HOME
LANG
SECURITYSESSIONID
VIRTUAL_ENV
TMPDIR
GIT_ASKPASS
LC_TERMINAL
POETRY_VIRTUALENVS_IN_PROJECT
VIRTUALENVWRAPPER_PYTHON
ZERO_TIER_TOKEN
TOOL_INSTALLER_BIN_DIR
BASH_SILENCE_DEPRECATION_WARNING
PIPENV_IGNORE_VIRTUALENVS
TOOL_INSTALLER_PIPX_HOME
VSCODE_GIT_ASKPASS_EXTRA_ARGS
WORKON_HOME
NPM_CONFIG_PREFIX
TERM
VSCODE_ENV_REPLACE
VSCODE_NONCE
ZDOTDIR
USER
PIP_DISABLE_PIP_VERSION_CHECK
VSCODE_GIT_IPC_HANDLE
COLORFGBG
RUNTOOL_DEV
PIPX_HOME
LC_TERMINAL_VERSION
TWILIO_PHONE_NUMBER
SHLVL
VIRTUAL_ENV_PROMPT
PYTHONDONTWRITEBYTECODE
XPC_SERVICE_NAME
TERMINFO_DIRS
PS1
NODE_PATH
VSCODE_GIT_ASKPASS_MAIN
TWILIO_AUTH_TOKEN
PATH
HOMEBREW_CASK_OPTS
HISTFILESIZE
ORIGINAL_XDG_CURRENT_DESKTOP
FZF_DEFAULT_OPTS
TOOL_INSTALLER_GIT_PROJECT_DIR
VSCODE_ENV_PREPEND
TOOL_INSTALLER_OPT_DIR
CODEFLASH_API_KEY
OLDPWD
__CF_USER_TEXT_ENCODING
TERM_PROGRAM
_
PYTHONFINDER_IGNORE_UNSUPPORTED
Pipenv–specific environment variables:
PIPENV_ACTIVE
:1
PIPENV_IGNORE_VIRTUALENVS
:1
Debug–specific environment variables:
PATH
:/Users/flavio/.virtualenvs/pipenv-KZWbNTkA/bin:/Users/flavio/.node_global/lib/node_modules/.bin:/Users/flavio/.node_global/bin:/Users/flavio/opt/runtool/bin:/Users/flavio/.local/bin:/Users/flavio/Applications/brew/bin:/Users/flavio/.node_global/lib/node_modules/.bin:/Users/flavio/.node_global/bin:/Users/flavio/opt/runtool/bin:/Users/flavio/.local/bin:/Users/flavio/Applications/brew/bin:/Users/flavio/.vscode/extensions/ms-python.python-2024.14.1-darwin-arm64/python_files/deactivate/zsh:/Users/flavio/.virtualenvs/pipenv-KZWbNTkA/bin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Users/flavio/.vscode/extensions/ms-python.python-2024.14.1-darwin-arm64/python_files/deactivate/zsh:/Users/flavio/.virtualenvs/pipenv-KZWbNTkA/bin:/Users/flavio/.node_global/lib/node_modules/.bin:/Users/flavio/.node_global/bin:/Users/flavio/opt/runtool/bin:/Users/flavio/.local/bin:/Users/flavio/Applications/brew/bin:/Users/flavio/Applications/iTerm.app/Contents/Resources/utilities
SHELL
:/bin/zsh
LANG
:en_US.UTF-8
PWD
:/Users/flavio/dev/github.com/FlavioAmurrioCS/pipenv/bug_small
VIRTUAL_ENV
:/Users/flavio/.virtualenvs/pipenv-KZWbNTkA
Contents of
Pipfile
('/Users/flavio/dev/github.com/FlavioAmurrioCS/pipenv/bug_small/Pipfile'):Contents of
Pipfile.lock
('/Users/flavio/dev/github.com/FlavioAmurrioCS/pipenv/bug_small/Pipfile.lock'):The text was updated successfully, but these errors were encountered: