-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setuptools changed behaviour of pip wheel #247
Comments
Do you have a reference to what changed? Sounds quite annoying, indeed. It feels like our tests should have detected this? :-/ |
Not yet. I found that when I restart build it behave different. |
I agree, this kind of thing suggests to me that deterministic builds by default would be a good idea. Tests are still passing here, so maybe it was only a temporary bug that got fixed. |
@joerick This is connected with PEP 517. Test build does not use PEP 517 and 518 so are not affected. |
Hmm, maybe we should include a test that uses pyproject.toml so we have visibility on this... |
I observe that updates of
setuptools
(I have hope that I identify correct) changed behavior ofpip wheel ..
command. It creates sub environment and install some packages from scratch. In this moment I'm not exactly sure what this change globally (for me it breaks using pre-release wheel package).This is also argument for #239 suggested pininng of packages.
In this moment I'm not sure how big impact of this change is on
cibuildwheel
. It should be at least additional notes in documentation.The text was updated successfully, but these errors were encountered: