Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setuptools changed behaviour of pip wheel #247

Closed
Czaki opened this issue Jan 16, 2020 · 5 comments
Closed

Setuptools changed behaviour of pip wheel #247

Czaki opened this issue Jan 16, 2020 · 5 comments

Comments

@Czaki
Copy link
Contributor

Czaki commented Jan 16, 2020

I observe that updates of setuptools (I have hope that I identify correct) changed behavior of pip wheel .. command. It creates sub environment and install some packages from scratch. In this moment I'm not exactly sure what this change globally (for me it breaks using pre-release wheel package).

This is also argument for #239 suggested pininng of packages.

In this moment I'm not sure how big impact of this change is on cibuildwheel. It should be at least additional notes in documentation.

@YannickJadoul
Copy link
Member

Do you have a reference to what changed?

Sounds quite annoying, indeed. It feels like our tests should have detected this? :-/

@Czaki
Copy link
Contributor Author

Czaki commented Jan 16, 2020

Not yet. I found that when I restart build it behave different.
In my case it is connected with #156. I observe that it stop setting proper wheel name. I found that it install wheel from pypi instead of use local one.

@joerick
Copy link
Contributor

joerick commented Jan 18, 2020

I agree, this kind of thing suggests to me that deterministic builds by default would be a good idea.

Tests are still passing here, so maybe it was only a temporary bug that got fixed.

@joerick joerick closed this as completed Jan 18, 2020
@Czaki
Copy link
Contributor Author

Czaki commented Jan 18, 2020

@joerick This is connected with PEP 517. Test build does not use PEP 517 and 518 so are not affected.

@joerick
Copy link
Contributor

joerick commented Jan 18, 2020

Hmm, maybe we should include a test that uses pyproject.toml so we have visibility on this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants