Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug introduced by rasterio update #745

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Dekermanjian
Copy link
Contributor

@Dekermanjian Dekermanjian commented Nov 17, 2024

Fixed bug introduced by rasterio update

Resolves issue #735


📚 Documentation preview 📚: https://pymc-examples--745.org.readthedocs.build/en/745/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good. I just realized that the notebook uses the extra dependencies template but doesn't specify which are the dependencies in the metadata. Do you mind fixing this here too?

Here is how the dropdown looks for this notebook:

imatge

And how it looks for one of the HSGP ones that also uses the template:

imatge

@Dekermanjian
Copy link
Contributor Author

@OriolAbril yes, I will definitely fix it! Sorry, I didn't realize it wasn't correct earlier.

@Dekermanjian
Copy link
Contributor Author

Hey @OriolAbril, how do I add the dependencies into the metadata? I tried adding it straight into the associated .myst.md file but that doesn't seem the right way to do it.

@OriolAbril
Copy link
Member

changes in the myst files get overriden by the contents of the jupyternotebook in pre-commit. You have to either follow the instructions in https://www.pymc.io/projects/docs/en/latest/contributing/jupyter_style.html#extra-dependencies or modify the myst file, then manually call jupytext to convert myst->ipynb before pre-commit (not sure if outputs will be removed when doing this so I'd recommend the first option)

@Dekermanjian
Copy link
Contributor Author

Thanks, @OriolAbril! I added the metadata and pushed the changes. Quick question, I wasn't able to figure out how to update the metadata using VSCode editor and had to launch Jupyter Lab in the web browser to do it. Do you know if it is possible to do it straight in the VSCode editor?

@OriolAbril
Copy link
Member

I don't use vscode but it would be nice to add how to do it from there to the docs

@Dekermanjian
Copy link
Contributor Author

@OriolAbril I figured out how to do it in VSCode.
At the top of the notebook to the right you need to click the '...' and select "edit cell tags (json)"
image

This will open a side panel. If you scroll all the way to the bottom you can add the dependencies:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants