-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requirements file missing #65
Comments
I don't think that either a requirements.txt nor a Pipfile are a good approach for dealing with library dependencies. I do, however, think that a Pipfile.lock (and thus a Pipfile) is a really good approach for dealing with development dependencies and pinning dependencies for development. I find Pipfile and pipenv to be superior to just using pip and requirements.txt files. What this means practically is that I want all the generic dependencies to be kept in the Thanks for bringing it up. I think a PR would be great! |
@ryanhiebert Sorry for the delay on this. It proved to be a bit trickier than it seemed, I have problems with In the meantime this was the [[source]]
name = "pypi"
url = "https://pypi.python.org/simple"
verify_ssl = true
[dev-packages]
oauthlib = "*"
lxml = "*"
requests-oauthlib = "*"
tox = "*"
sphinx = "*"
tox-pipenv = "*"
[packages]
lti = {editable = true, path = "."}
[requires]
python_version = "3.5" One of the problems for tox is probably the fixed Python version in the Pipfile. |
The repo does not contain neither requirements nor
Pipfile
. It would be good to add such a file for people who would like to contribute in the future. I suggest that we usePipfile
because it can differentiate between regular and development dependencies. I can make a PR to add the file, if everyone are OK with the idea. The only thing I'm not sure is whether thepipenv
is the good tool to deal with library dependencies?The text was updated successfully, but these errors were encountered: