-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address Sanitizer complaining about heap-buffer-overflow in [PKMultipartElement read:maxLength:] #18
Comments
The other thing I can say is that this happens intermittently on a request basis, and not with every request. If I make a stream with different data in the same app build, it seems to be fine, but fails 100% of the time with this specific stream. |
Oh, interesting. I've been getting intermittent crash reports about something very similar, but on a slightly different line and with less helpful information. Sounds like they might be related, I've been unsure on how to dig deeper. It does seem to be content related, I don't see this crash very often but it happens repeatedly for the same people.
|
Yeah, this is a tricky one to figure out. It works completely fine 99.99% of the time, but occasionally we get a crash or two. Best I can tell, the buffer is overflowing for some reason, which causes some strange memory issues in the app. |
Hi, any chance you could reproduce and send a PR to fix? Thx. |
I've got a demo app written in Swift at https://github.com/robertcopper/PKMultipartInputStreamDemo Can you change the code in the |
I enabled Address Sanitizer after seeing complaints from malloc about memory checksums, and it pointed me to [PKMultipartElement read:maxLength:]. Specifically line 176, where it says:
*(buffer + sent) = '\n';
Backtrace:
Here's the full text from Address Sanitizer:
Any ideas what could be happening here? Happy to provide whatever data is helpful.
The text was updated successfully, but these errors were encountered: