Skip to content

Commit

Permalink
remove dynamic loading for first section. change title level of secti…
Browse files Browse the repository at this point in the history
…on title component.
  • Loading branch information
pyj-pd committed Nov 24, 2024
1 parent 9fddb59 commit b32e515
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
6 changes: 5 additions & 1 deletion src/components/picker/SectionTitle.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ defineProps<{

<template>
<div :class="$style.title">
<h2>{{ $props.title }}</h2>
<h3>{{ $props.title }}</h3>
<p v-if="$props.description" :class="$style.description">{{ $props.description }}</p>
</div>
</template>
Expand All @@ -20,6 +20,10 @@ defineProps<{
gap: 5px;
width: 100%;
h3 {
font-size: 1.4rem;
}
}
.description {
Expand Down
7 changes: 2 additions & 5 deletions src/constants/section.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { defineAsyncComponent, type Component } from 'vue'
import LoadingSection from '@/components/picker/sections/LoadingSection.vue'
import type { RouteName } from '@/router'
import SizeSettings from '@/components/picker/sections/SizeSettings.vue'

export const DEFAULT_SHOW_TITLE = true,
DEFAULT_FULLSCREEN = true
Expand All @@ -26,11 +27,7 @@ export type SectionList = {
export const sections = {
'size-settings': {
title: '자리 배치 설정',
component: defineAsyncComponent({
/** @todo use Suspense instead of repeating the same code */
loader: () => import('@/components/picker/sections/SizeSettings.vue'),
loadingComponent: LoadingSection,
}),
component: SizeSettings,
},
'name-settings': {
title: '이름 설정',
Expand Down

0 comments on commit b32e515

Please sign in to comment.