Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of what the expected and observed CLs values actually are #10

Open
matthewfeickert opened this issue Oct 6, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@matthewfeickert
Copy link
Member

Given @sabinekraml's good GitHub Discussion question (that we've seen before in Issues) scikit-hep/pyhf#1619, along with scikit-hep/pyhf#1620 we should make this more explicit by adding a notebook that demonstrates the differences between the expected and observed CLs values given

If you switch from observed data to expected data — your background-only model will have NPs centered at different values because they're fit to different datasets. The expected CLs has to be different.

cc @kratsg @lukasheinrich

@matthewfeickert matthewfeickert added the enhancement New feature or request label Oct 6, 2021
@matthewfeickert
Copy link
Member Author

@alexander-held I'll probably also ask you to review the PR that ends up addressing this. 🙂

@alexander-held
Copy link

alexander-held commented Oct 6, 2021

Another (slightly) related issue: scikit-hep/pyhf#1587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants